Skip to content

Commit 0bf2e84

Browse files
authored
fix: consistent casing for afterLiveQueryEvent (#7023)
1 parent d4f405d commit 0bf2e84

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

spec/ParseLiveQuery.spec.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe('ParseLiveQuery', function () {
3838
silent: true,
3939
});
4040
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
41-
expect(req.event).toBe('Create');
41+
expect(req.event).toBe('create');
4242
expect(req.user).toBeUndefined();
4343
expect(req.object.get('foo')).toBe('bar');
4444
});
@@ -68,7 +68,7 @@ describe('ParseLiveQuery', function () {
6868
await object.save();
6969

7070
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
71-
expect(req.event).toBe('Update');
71+
expect(req.event).toBe('update');
7272
expect(req.user).toBeUndefined();
7373
expect(req.object.get('foo')).toBe('bar');
7474
expect(req.original.get('foo')).toBeUndefined();
@@ -92,7 +92,7 @@ describe('ParseLiveQuery', function () {
9292
silent: true,
9393
});
9494
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
95-
expect(req.event).toBe('Enter');
95+
expect(req.event).toBe('enter');
9696
expect(req.user).toBeUndefined();
9797
expect(req.object.get('foo')).toBe('bar');
9898
expect(req.original.get('foo')).toBeUndefined();
@@ -123,7 +123,7 @@ describe('ParseLiveQuery', function () {
123123
silent: true,
124124
});
125125
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
126-
expect(req.event).toBe('Leave');
126+
expect(req.event).toBe('leave');
127127
expect(req.user).toBeUndefined();
128128
expect(req.object.get('foo')).toBeUndefined();
129129
expect(req.original.get('foo')).toBe('bar');
@@ -155,7 +155,7 @@ describe('ParseLiveQuery', function () {
155155
silent: true,
156156
});
157157
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
158-
expect(req.event).toBe('Delete');
158+
expect(req.event).toBe('delete');
159159
expect(req.user).toBeUndefined();
160160
req.object.set('foo', 'bar');
161161
});
@@ -315,7 +315,7 @@ describe('ParseLiveQuery', function () {
315315
silent: true,
316316
});
317317
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
318-
expect(req.event).toBe('Create');
318+
expect(req.event).toBe('create');
319319
expect(req.user).toBeUndefined();
320320
expect(req.object.get('foo')).toBe('bar');
321321
});
@@ -345,7 +345,7 @@ describe('ParseLiveQuery', function () {
345345
await object.save();
346346

347347
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
348-
expect(req.event).toBe('Update');
348+
expect(req.event).toBe('update');
349349
expect(req.user).toBeUndefined();
350350
expect(req.object.get('foo')).toBe('bar');
351351
expect(req.original.get('foo')).toBeUndefined();
@@ -369,7 +369,7 @@ describe('ParseLiveQuery', function () {
369369
silent: true,
370370
});
371371
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
372-
expect(req.event).toBe('Enter');
372+
expect(req.event).toBe('enter');
373373
expect(req.user).toBeUndefined();
374374
expect(req.object.get('foo')).toBe('bar');
375375
expect(req.original.get('foo')).toBeUndefined();
@@ -400,7 +400,7 @@ describe('ParseLiveQuery', function () {
400400
silent: true,
401401
});
402402
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
403-
expect(req.event).toBe('Leave');
403+
expect(req.event).toBe('leave');
404404
expect(req.user).toBeUndefined();
405405
expect(req.object.get('foo')).toBeUndefined();
406406
expect(req.original.get('foo')).toBe('bar');
@@ -432,7 +432,7 @@ describe('ParseLiveQuery', function () {
432432
silent: true,
433433
});
434434
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
435-
expect(req.event).toBe('Delete');
435+
expect(req.event).toBe('delete');
436436
expect(req.user).toBeUndefined();
437437
req.object.set('foo', 'bar');
438438
});

src/LiveQuery/ParseLiveQueryServer.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ class ParseLiveQueryServer {
160160
return null;
161161
}
162162
res = {
163-
event: 'Delete',
163+
event: 'delete',
164164
sessionToken: client.sessionToken,
165165
object: deletedParseObject,
166166
clients: this.clients.size,
@@ -275,14 +275,14 @@ class ParseLiveQueryServer {
275275
// Decide event type
276276
let type;
277277
if (isOriginalMatched && isCurrentMatched) {
278-
type = 'Update';
278+
type = 'update';
279279
} else if (isOriginalMatched && !isCurrentMatched) {
280-
type = 'Leave';
280+
type = 'leave';
281281
} else if (!isOriginalMatched && isCurrentMatched) {
282282
if (originalParseObject) {
283-
type = 'Enter';
283+
type = 'enter';
284284
} else {
285-
type = 'Create';
285+
type = 'create';
286286
}
287287
} else {
288288
return null;
@@ -315,7 +315,8 @@ class ParseLiveQueryServer {
315315
originalParseObject = res.original.toJSON();
316316
originalParseObject.className = res.original.className || className;
317317
}
318-
const functionName = 'push' + message.event;
318+
const functionName =
319+
'push' + message.event.charAt(0).toUpperCase() + message.event.slice(1);
319320
if (client[functionName]) {
320321
client[functionName](requestId, currentParseObject, originalParseObject);
321322
}

0 commit comments

Comments
 (0)