Skip to content

Some S3 compatible storages don't support tags #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarsonj opened this issue Jan 14, 2021 · 3 comments
Closed

Some S3 compatible storages don't support tags #134

sarsonj opened this issue Jan 14, 2021 · 3 comments

Comments

@sarsonj
Copy link

sarsonj commented Jan 14, 2021

We are using Digital Ocean spaces and they don't support tags. The API simply returns error when there are tags in file upload request. So that this file adapter don't work with Digital Ocean spaces now.

What I suggest is to send tags only when tags are actually presented in file options. It should be safe - when somebody wants to use tags in their project, it has to use storage with tags support. And from the other way - it has no benefit to send empty tags dictionary to the S3.

I created pull request, that handles this.

@sarsonj
Copy link
Author

sarsonj commented Jan 14, 2021

Pull request #135

@sarsonj
Copy link
Author

sarsonj commented Jan 18, 2021

Related issue in Parse Server repo: parse-community/parse-server#7129

@mtrezza
Copy link
Member

mtrezza commented Apr 2, 2021

This should be fixed by parse-community/parse-server#7300

@mtrezza mtrezza closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants