APN with HTTP/2 #72
Merged
APN with HTTP/2 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Schwobaland I just pushed here, rebased on master with extensive coverage. The only missing part is the retry on another connection upon failure. |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 249 249
=====================================
Hits 249 249
Continue to review full report at Codecov.
|
|
@flovilmart looks good :) Shall I close #52? I think we don't need it anymore. |
|
Yes! Thanks for your hard work! I also just added the retry mechanism, let me know what you think? (fbe235b#diff-0388cf95ecca43f50bfebf698a4c0e3bR110) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.