Skip to content

Adds Fix for Changed Push Status Life Cycle #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Mar 5, 2018

This adds a small fix to our test suite that was affected by a change to the push status life cycle. Originally we could create a dummy set of pushes and expect it to be marked as 'failed'. That has since changed to be marked as 'succeeded'. In terms of functionality nothing has really changed, but the reported push statuses didn't match up with what we were expecting.

The adjustment to the tests should still pass with servers using the old push status life cycle.

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          38       38           
  Lines        3116     3116           
=======================================
  Hits         3084     3084           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef7394...ea7a6bc. Read the comment docs.

@montymxb montymxb merged commit 03893ac into parse-community:master Mar 14, 2018
@montymxb montymxb deleted the push-status-test-fix branch July 24, 2018 21:38
@parse-github-assistant
Copy link

The label type:feature cannot be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants