Adds Fix for Changed Push Status Life Cycle #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small fix to our test suite that was affected by a change to the push status life cycle. Originally we could create a dummy set of pushes and expect it to be marked as 'failed'. That has since changed to be marked as 'succeeded'. In terms of functionality nothing has really changed, but the reported push statuses didn't match up with what we were expecting.
The adjustment to the tests should still pass with servers using the old push status life cycle.