-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adds distribution with built package #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
flovilmart
commented
Mar 6, 2016
- Adds gulp build system to build the parse-dashboard dist
- Adds instruction for safe production deployments
- Adds ability to build npm package
- npm package only contains dist/ and optimized bundles
- 5 steps configuration for production deployments.
By analyzing the blame information on this pull request, we identified @flovilmart, @drew-gross and @hallucinogen to be potential reviewers. |
@@ -104,6 +104,16 @@ If you are not familiar with Docker, ``--port 8080`` with be passed in as argume | |||
|
|||
## Deploying in production | |||
|
|||
For production deployments, it's recommended to use the npm pacakge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package (sp)
other than the two comments, lgtm! |
@peterdotjs version 1.0.0 is right? @drew-gross has the access to npmjs to publish the package, I can't publish it :( |
0f17c53
to
2673b87
Compare
@flovilmart updated the pull request. |
Only @drew-gross I think has publish perms. Drew could you give us permissions? Hmm regarding version # we could go the same route as |
bumped to 2.0.0, at publish time, @drew-gross could lower leave it |
2673b87
to
e60052f
Compare
@flovilmart updated the pull request. |
Adds distribution with built package
@flovilmart what benefit do we get from gulp in this case? It doesn't seem like it's doing much right now, and I don't really want to add an entire other build step unless it solves a really big problem. |
@drew-gross webpack is really bad at moving files around, and it would likely require another package, like webpack-copy-files, a new webpack config, based on production. I don't mind removing gulp, but I tried with webpack and never got a good reliable solution. I'm open to remove gulp. |
@flovilmart why would webpack need to move files around? Seems like you should be able to just change the output directory. |
We need to copy the dashboard files into dist, that is not committed, and only created upon publish. |
Analytics report event