Skip to content

Adds distribution with built package #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Conversation

flovilmart
Copy link
Contributor

  • Adds gulp build system to build the parse-dashboard dist
  • Adds instruction for safe production deployments
  • Adds ability to build npm package
  • npm package only contains dist/ and optimized bundles
  • 5 steps configuration for production deployments.

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @flovilmart, @drew-gross and @hallucinogen to be potential reviewers.

@@ -104,6 +104,16 @@ If you are not familiar with Docker, ``--port 8080`` with be passed in as argume

## Deploying in production

For production deployments, it's recommended to use the npm pacakge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package (sp)

@peterdotjs
Copy link
Contributor

other than the two comments, lgtm!

@flovilmart
Copy link
Contributor Author

@peterdotjs version 1.0.0 is right? @drew-gross has the access to npmjs to publish the package, I can't publish it :(

@flovilmart flovilmart force-pushed the flovilmart.npmDist branch from 0f17c53 to 2673b87 Compare March 6, 2016 16:43
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@peterdotjs
Copy link
Contributor

Only @drew-gross I think has publish perms. Drew could you give us permissions?

Hmm regarding version # we could go the same route as parse-server and start with 2.0.0? Thoughts @gfosco ?

@flovilmart
Copy link
Contributor Author

bumped to 2.0.0, at publish time, @drew-gross could lower leave it

@flovilmart flovilmart force-pushed the flovilmart.npmDist branch from 2673b87 to e60052f Compare March 6, 2016 17:00
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart added a commit that referenced this pull request Mar 6, 2016
Adds distribution with built package
@flovilmart flovilmart merged commit c506ba1 into master Mar 6, 2016
@flovilmart flovilmart deleted the flovilmart.npmDist branch March 6, 2016 17:20
@drew-gross
Copy link
Contributor

@flovilmart what benefit do we get from gulp in this case? It doesn't seem like it's doing much right now, and I don't really want to add an entire other build step unless it solves a really big problem.

@flovilmart
Copy link
Contributor Author

@drew-gross webpack is really bad at moving files around, and it would likely require another package, like webpack-copy-files, a new webpack config, based on production. I don't mind removing gulp, but I tried with webpack and never got a good reliable solution. I'm open to remove gulp.

@drew-gross
Copy link
Contributor

@flovilmart why would webpack need to move files around? Seems like you should be able to just change the output directory.

@flovilmart
Copy link
Contributor Author

We need to copy the dashboard files into dist, that is not committed, and only created upon publish.

douglasmuraoka pushed a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants