feat: add custom branding with icon, brand name and color #1657

stepanic · 2021-02-20T21:38:59Z

parse-dashboard-config.json is improved with this options:

...
"customBrandIcon": "scanshop-logo-transparent.svg",
"customBrandTitle": "ScanShop Dashboard",
"customBrandColorPrimary": "#00A0FF",
...

NOTE: favicon and HTML title are on purpose kept unchanged and background color inside of React app.

This is initial version of custom branding, any more advanced custom branding could be implemented in another PR.

From default sidebar

to branded sidebar

From default login form

to branded login form

ghost · 2021-02-20T21:39:04Z

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by 🚫 dangerJS

404-html · 2021-02-26T14:16:03Z

src/components/LoginForm/LoginForm.react.js

    return (
      <div className={styles.login} style={{ marginTop: this.props.marginTop || '-220px' }}>
-        <Icon width={80} height={80} name='infinity' fill='#093A59' />
+        {!customBrandIcon && <Icon width={80} height={80} name='infinity' fill='#093A59' />}
+        {customBrandIcon && <img src={'appicons/' + customBrandIcon} width={80} height={80} alt="Custom BRAND icon"/>}


Can we put customBrandTitle into alt attribute, if available? Otherwise "Brand Logo" should be enough I think.

I changed this.

Parse-Dashboard/app.js

… Logo'

stepanic · 2021-02-27T12:20:28Z

@404-html the both comments solved.

README.md

Parse-Dashboard/app.js

mtrezza · 2021-09-04T22:00:26Z

@stepanic Thanks for this PR! And apologies that it didn't get much review attention anymore. We are on a spree now to close all open PRs. Could you rebase this on master and resolve any merge conflicts? It would be amazing if we could get this merged!

stepanic · 2021-09-05T11:33:41Z

@stepanic Thanks for this PR! And apologies that it didn't get much review attention anymore. We are on a spree now to close all open PRs. Could you rebase this on master and resolve any merge conflicts? It would be amazing if we could get this merged!

@mtrezza conflict was resolved.

mtrezza · 2021-09-05T12:14:58Z

That was amazingly fast! I'll review this feature, @404-html do you maybe have any input in the meantime?

404-html · 2021-09-05T15:43:19Z

Nothing new from me, thanks for asking. I left some suggestions back in the day but nothing urgent 👍

mtrezza · 2021-09-05T16:13:08Z

Great! Could you look through the suggestions and see which ones you would mark as resolved? It seems most have been addressed.

stepanic · 2021-09-05T18:49:34Z

@404-html I see that you left suggestions on 2021-05-19, which are only README related will you commit them and then integrate this PR?

404-html · 2021-09-07T19:24:57Z

Sorry @stepanic, looks like I don't have permission:

Also, I can't see an option to resolve those. Is there any "Apply" button next to my suggestions? If not I think we can skip them, they are minor.

mtrezza · 2021-09-07T22:46:02Z

@404-html This may be if you had write access at some point. We have recently changes our permission model and are limiting write permissions to reviewers to are active on a regular basis, for security reasons, because the write permissions are quite wide-ranging.

@stepanic Could you incorporate the change suggestions and resolve the conversations that have been addressed? Then we can easily see whether there are any open questions. I'm preparing a release, so it would be great to get this feature in there.

Co-authored-by: 404-html <[email protected]>

stepanic · 2021-09-08T20:54:07Z

@mtrezza @404-html suggestions commited

mtrezza · 2021-09-09T12:02:36Z

@stepanic There have been some merges on master, could you please rebase/merge and then request a review?

* upstream/master: docs: Update node in README Update sass and docker (parse-community#1792) ci: Remove parse server dev dependency (parse-community#1796) ci: modernize steps (parse-community#1789) fix(docker): increase node version in docker to 12 (parse-community#1788) Fix: Update CLP for new class (parse-community#1785) feat: Add MFA to Dashboard (parse-community#1624) ci: refactor docker ci (parse-community#1786) ci: Fix docker image pushing to Docker Hub (parse-community#1781)

stepanic · 2021-09-15T10:16:00Z

@mtrezza merged with master without conflicts :D

$ git merge upstream/master
Auto-merging src/components/LoginForm/LoginForm.react.js
Removing server.js
Auto-merging README.md
Merge made by the 'recursive' strategy.
 .github/workflows/ci.yml                    |  169 +++-
 .github/workflows/docker-publish.yml        |   62 ++
 CHANGELOG.md                                |    8 +
 Dockerfile                                  |    4 +-
 Parse-Dashboard/Authentication.js           |   34 +-
 Parse-Dashboard/CLI/mfa.js                  |  225 +++++
 Parse-Dashboard/CLI/utils.js                |    7 +
 Parse-Dashboard/CLIHelper.js                |    6 +
 Parse-Dashboard/index.js                    |   11 +
 README.md                                   |   43 +-
 ci/CiVersionCheck.js                        |  290 ++++++
 ci/ciCheck.js                               |   36 +
 ci/nodeEngineCheck.js                       |  187 ++++
 package-lock.json                           | 5489 +++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
 package.json                                |   22 +-
 server.js                                   |   19 -
 src/components/LoginForm/LoginForm.react.js |    1 +
 src/dashboard/Dashboard.js                  |    2 +
 src/lib/stores/SchemaStore.js               |    4 +-
 src/login/Login.js                          |   39 +-
 20 files changed, 3332 insertions(+), 3326 deletions(-)
 create mode 100644 .github/workflows/docker-publish.yml
 create mode 100644 Parse-Dashboard/CLI/mfa.js
 create mode 100644 Parse-Dashboard/CLI/utils.js
 create mode 100644 Parse-Dashboard/CLIHelper.js
 create mode 100644 ci/CiVersionCheck.js
 create mode 100644 ci/ciCheck.js
 create mode 100644 ci/nodeEngineCheck.js
 delete mode 100755 server.js

mtrezza · 2021-09-16T10:12:41Z

@stepanic Could you please merge master into this? It again became out-of-date with the base branch. I'll make sure to review this next, so you don't have to do this again.

* upstream/master: fix: revert parse-community#1706 which introduced new database index requirements for pagination (parse-community#1800)

stepanic · 2021-09-16T11:56:23Z

@mtrezza merged again :D

mtrezza

This is looking good! A few notes:

The path for customBrandIcon seems to be hard coded to .../appicons/<file>. Can you use the path specified in the existing iconsFolder config option instead? That is the path used for app specific icons, I guess it can also be used for this purpose since they are related.
Could you remove the custom... prefix from the new options, e.g. rename customBrandIcon to brandIcon. Any option is inherently a customization. And please also remove custom... from the code variables to keep the relation between code and feature.
Could you rename customBrandTitle to brandName, a "brand name" is a more commonly known term.
Could you rename customBrandColorPrimary to brandPrimaryBackgroundColor, similar to the existing primaryBackgroundColor for apps. I can imagine that in the future someone may add a brandPrimaryForegroundColor color to specify the text color.
There seems to be a layout issue, in the top left title bar:

previously it was:

which was also not optimal, because the title and user are not vertically centered. Maybe, while you are at it, you could fix this and center the text, if not, a future PR can do this. It should be centered, regardless of whether there is a username or not (if you have no users set in dashboard config).

mtrezza · 2021-09-27T12:32:03Z

@stepanic If you have some time, it would be great if you could look over the feedback above, so we can merge this PR.

mtrezza · 2021-10-20T14:00:05Z

@visualfanatic If you are interested in completing this PR, I think there is not much missing. The feature now has a bounty applied to it since the PR has become stale.

andreafalzetti · 2021-11-20T23:29:56Z

I would love to see this landing!

mtrezza · 2021-11-21T13:50:17Z

@andreafalzetti Feel free to pick it up if you like, it seems to be almost done.

Custom branding with custom icon, title and color

c01beab

404-html reviewed Feb 26, 2021

View reviewed changes

Review correction: customBrandTitle as img.alt and fallback to 'Brand…

c509c2d

… Logo'

404-html reviewed May 19, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Parse-Dashboard/app.js Show resolved Hide resolved

Merge branch 'master' into custom-branding

c20ad54

404-html previously approved these changes Sep 7, 2021

View reviewed changes

stepanic and others added 3 commits September 8, 2021 22:52

Update README.md

dba20a0

Co-authored-by: 404-html <[email protected]>

Update README.md

a128835

Co-authored-by: 404-html <[email protected]>

Update README.md

df8c094

Co-authored-by: 404-html <[email protected]>

mtrezza changed the title ~~Custom branding with custom icon, title and color~~ feat: add custom branding with icon, title and color Sep 16, 2021

parse-community deleted a comment from parse-github-assistant bot Sep 16, 2021

Merge remote-tracking branch 'upstream/master' into custom-branding

4d44530

* upstream/master: fix: revert parse-community#1706 which introduced new database index requirements for pagination (parse-community#1800)

mtrezza requested changes Sep 19, 2021

View reviewed changes

mtrezza changed the title ~~feat: add custom branding with icon, title and color~~ feat: add custom branding with icon, brand name and color Sep 19, 2021

parse-community deleted a comment from parse-github-assistant bot Sep 19, 2021

mtrezza mentioned this pull request Oct 20, 2021

Add custom branding with icon, brand name and color #1877

Open

3 tasks

mtrezza linked an issue Oct 20, 2021 that may be closed by this pull request

Add custom branding with icon, brand name and color #1877

Open

3 tasks

mtrezza mentioned this pull request Oct 20, 2021

ci: fix lint and add husky hook #1791

Closed

5 tasks

snyk-bot mentioned this pull request Mar 25, 2022

refactor: upgrade commander from 6.2.1 to 9.0.0 #2073

Merged

mtrezza dismissed 404-html’s stale review via 4d44530 April 3, 2022 15:43

mtrezza force-pushed the alpha branch from d32a043 to 0f42a34 Compare May 1, 2022 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add custom branding with icon, brand name and color #1657

feat: add custom branding with icon, brand name and color #1657

stepanic commented Feb 20, 2021

ghost commented Feb 20, 2021 •

edited by ghost

Loading

404-html Feb 26, 2021

stepanic Feb 27, 2021

stepanic commented Feb 27, 2021

mtrezza commented Sep 4, 2021

stepanic commented Sep 5, 2021

mtrezza commented Sep 5, 2021

404-html commented Sep 5, 2021

mtrezza commented Sep 5, 2021 •

edited

Loading

stepanic commented Sep 5, 2021

404-html commented Sep 7, 2021 •

edited

Loading

mtrezza commented Sep 7, 2021 •

edited

Loading

stepanic commented Sep 8, 2021

mtrezza commented Sep 9, 2021 •

edited

Loading

stepanic commented Sep 15, 2021

mtrezza commented Sep 16, 2021 •

edited

Loading

stepanic commented Sep 16, 2021

mtrezza left a comment •

edited

Loading

mtrezza commented Sep 27, 2021

mtrezza commented Oct 20, 2021 •

edited

Loading

andreafalzetti commented Nov 20, 2021

mtrezza commented Nov 21, 2021

feat: add custom branding with icon, brand name and color #1657

Are you sure you want to change the base?

feat: add custom branding with icon, brand name and color #1657

Conversation

stepanic commented Feb 20, 2021

ghost commented Feb 20, 2021 • edited by ghost Loading

404-html Feb 26, 2021

Choose a reason for hiding this comment

stepanic Feb 27, 2021

Choose a reason for hiding this comment

stepanic commented Feb 27, 2021

mtrezza commented Sep 4, 2021

stepanic commented Sep 5, 2021

mtrezza commented Sep 5, 2021

404-html commented Sep 5, 2021

mtrezza commented Sep 5, 2021 • edited Loading

stepanic commented Sep 5, 2021

404-html commented Sep 7, 2021 • edited Loading

mtrezza commented Sep 7, 2021 • edited Loading

stepanic commented Sep 8, 2021

mtrezza commented Sep 9, 2021 • edited Loading

stepanic commented Sep 15, 2021

mtrezza commented Sep 16, 2021 • edited Loading

stepanic commented Sep 16, 2021

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza commented Sep 27, 2021

mtrezza commented Oct 20, 2021 • edited Loading

andreafalzetti commented Nov 20, 2021

mtrezza commented Nov 21, 2021

ghost commented Feb 20, 2021 •

edited by ghost

Loading

mtrezza commented Sep 5, 2021 •

edited

Loading

404-html commented Sep 7, 2021 •

edited

Loading

mtrezza commented Sep 7, 2021 •

edited

Loading

mtrezza commented Sep 9, 2021 •

edited

Loading

mtrezza commented Sep 16, 2021 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Oct 20, 2021 •

edited

Loading