Skip to content

Context menu with quick filters and links to related records in other Parse Objects 📃 #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Mar 4, 2020

Conversation

404-html
Copy link
Member

@404-html 404-html commented Dec 21, 2019

Handy context menu which allows:

  • set filter;
  • add filter;
  • get related records from other Object;
  • open "Edit row" dialog.

See it in action:

filter5

TODO:

  • generate context menu items dynamically with taking data type into account;
  • sort objects listed in context menu alphabetically;
  • make an exceptions for cells with data that is non-filterable;
  • context menu to expand sub items on the other side if there's not enough space;
  • add third context menu option. Option should be available only when clicking on Pointer type of cell or cell under objectId column. Option should say something like: "Get records in relation from...". Selecting this option should expand sub menu with Objects that have data related with this specific id. Clicking on any object listed should navigate to it with proper filter applied;
  • context menu to close after choosing an item (good to be configurable via props);
  • context menu to close after clicking outside it;
  • move ContextMenu item in pig list to keep alphabetical order (currently is at the bottom of the list);
  • context menu to work when clicking on empty cell.

@dplewis
Copy link
Member

dplewis commented Dec 24, 2019

Thanks for the contribution! I'll pull this down and try it out.

Does this work on mobile?

@404-html
Copy link
Member Author

404-html commented Dec 24, 2019

Hey @dplewis,

Does this work on mobile?

I doubt, it's still in early stage. I created this MR for someone to check whether I'm not doing something terribly wrong. I should push more in next few days.

@404-html
Copy link
Member Author

I've slightly changed the approach and created general ContextMenu component instead of keeping it on Browser level.
I've also started putting items into TODO in the description.

Artur Drozdz and others added 22 commits December 25, 2019 02:40
@404-html 404-html changed the title WIP: Quick filters in context menu Context menu with quick filters and links to related records in other Parse Objects Dec 31, 2019
@404-html 404-html changed the title Context menu with quick filters and links to related records in other Parse Objects Context menu with quick filters and links to related records in other Parse Objects 📃 Dec 31, 2019
@404-html
Copy link
Member Author

Hey @dplewis,

I believe it's ready to be reviewed. I'm looking forward for any comments.

P.S. it works on mobile too :)

@davimacedo
Copy link
Member

@404-html would you mind to resolve the conflicts so we can merge it?

@davimacedo
Copy link
Member

I think it is not passing the lint. Can you please take a look?

@404-html
Copy link
Member Author

Sorry @davimacedo, I resolved conflicts using GitHub web UI as I don't know how to pull from master into forked repo, it's I shame.
Anyway I fixed lint errors and I'm open for any comments 👍

@404-html
Copy link
Member Author

Small addition: I've added "Edit row" context menu option which allows to quickly access recently introduced, lovely edit row dialog (cheers @NinoZX).

edit-row

@davimacedo davimacedo merged commit 69cab35 into parse-community:master Mar 4, 2020
@davimacedo
Copy link
Member

Nice job! Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants