-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: Sidebar collapse #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Sidebar collapse #1269
Conversation
@douglasmuraoka thanks for working on this. Few questions:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Please merge this. The dashboard sidebar needs a Fix. |
@tehsunnliu Thanks for bringing this to our attention. I think it just needs a rebase on master, then we can merge it. I'll look into that. |
There are some fixed necessary, continued in #1760 |
Hi @mtrezza Thank you so much for initiating this. I'll check this out. |
Removes the old
SidebarToggle
component and allows users to collapse the sidebar even when window width is greater than 980px. Adds aPin
button that fixes the sidebar, avoiding any collapses.Once collapsed, expands the sidebar when on mouse over, and collapses on mouse leave.
Collapsed:

Expanded:

Closes #1759.