Skip to content

Change Markdown comment type from JSON to JSON5 to allow comments #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Change Markdown comment type from JSON to JSON5 to allow comments #840

wants to merge 2 commits into from

Conversation

sadortun
Copy link
Contributor

@sadortun sadortun commented Aug 1, 2021 •
edited
Loading

Hi !

Fixed a few more comments.

JSON5 resemble much more regular JS objects and in most example it's what we are presenting. I would recommend

  • Using only ```json5 to show actual javascript objects
  • Using only ```json to show actual client/server JSON message

@MrMartinR MrMartinR mentioned this pull request Jun 13, 2022
Closed
@MrMartinR
Copy link
Contributor

This PR is obsolete now, because the issues was fixed in this and this PR
@parse-community/docs-review can you close this one?

@mtrezza
Copy link
Member

mtrezza commented Jul 3, 2022

Superseded by #883 and #885

@mtrezza mtrezza closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadortun @MrMartinR @mtrezza