Skip to content

Fixes lists floating through search box #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Jul 21, 2017

Some of the CSS that's used to render the Algolia autocomplete box doesn't exactly play very nicely with what's in the docs. This modifies the list CSS slightly to correct this issue. I've observed this in Firefox/Chrome/Safari, haven't checked Edge/IE but I suspect it may be in at least Edge as well.

The fix applied here is removing the relative positioning for li elements in the doc. This is to allow the + symbol to be absolutely positioned in front. With that change this also adjusts the before selector to create and position an inline-block entry that is not absolutely positioned. This puts it back in line, but to reposition it to how it was before the additional left & right margins were added.

Just for reference this is how it should look:

good1

And this is how it looks when you happen to be over a list:

bad1

Note that this also happens with anchors:

bad2

This addresses the lists only for now, if this isn't merged in before I'll go back and take a look at the anchors too.

Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Not sure I understand the fix :p

@flovilmart flovilmart merged commit 3575967 into parse-community:gh-pages Jul 21, 2017
@montymxb montymxb deleted the autocomplete-fix branch July 22, 2017 17:59
@montymxb
Copy link
Contributor Author

Haha, yeah css can be 'fun'. This patch didn't include anything for the little anchor links, I think I'll put something up for that later on. The big was the lists bleeding through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants