Accessibility identifiers: fixing typo, updating style to match code guidelines, improving uniqueness of accessibility identifiers

Author: huguesbr

ParseUI/Classes/LogInViewController/PFLogInView.h

@@ -62,14 +62,14 @@ typedef NS_OPTIONS(NSInteger, PFLogInFields) {
  
  @see PFLogInView
  */
-extern NSString * const PFLogInViewUsernameFieldAccessibilityIdentifier;
-extern NSString * const PFLogInViewPasswordFieldAccessibilityIdentifier;
-extern NSString * const PFLogInViewLogInButtonAccessibilityIdentifier;
-extern NSString * const PFLogInViewSignUpButtonAccessibilityIdentifier;
-extern NSString * const PFLogInViewPasswordForgottenButotnAccessibilityIdentifier;
-extern NSString * const PFLogInViewTwitterButtonAccessibilityIdentifier;
-extern NSString * const PFLogInViewFacebookButtonAccessibilityIdentifier;
-extern NSString * const PFLogInViewDismissButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewUsernameFieldAccessibilityIdentifier;
+extern NSString *const PFLogInViewPasswordFieldAccessibilityIdentifier;
+extern NSString *const PFLogInViewLogInButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewSignUpButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewPasswordForgottenButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewTwitterButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewFacebookButtonAccessibilityIdentifier;
+extern NSString *const PFLogInViewDismissButtonAccessibilityIdentifier;
 
 @class PFTextField;
 

ParseUI/Classes/LogInViewController/PFLogInView.m

@@ -35,15 +35,17 @@
 static NSString *const PFLogInViewDefaultFacebookButtonImageName = @"facebook_icon.png";
 static NSString *const PFLogInViewDefaultTwitterButtonImageName = @"twitter_icon.png";
 
-#pragma mark - Accessibility labels identifiers
-NSString * const PFLogInViewUsernameFieldAccessibilityIdentifier = @"username";
-NSString * const PFLogInViewPasswordFieldAccessibilityIdentifier = @"password";
-NSString * const PFLogInViewLogInButtonAccessibilityIdentifier = @"logIn";
-NSString * const PFLogInViewSignUpButtonAccessibilityIdentifier = @"signUp";
-NSString * const PFLogInViewPasswordForgottenButotnAccessibilityIdentifier = @"passwordForgotten";
-NSString * const PFLogInViewTwitterButtonAccessibilityIdentifier = @"twitter";
-NSString * const PFLogInViewFacebookButtonAccessibilityIdentifier = @"facebook";
-NSString * const PFLogInViewDismissButtonAccessibilityIdentifier = @"dismiss";
+///--------------------------------------
+#pragma mark - Accessibility Identifiers
+///--------------------------------------
+NSString *const PFLogInViewUsernameFieldAccessibilityIdentifier = @"PFLogInViewUsernameFieldAccessibilityIdentifier";
+NSString *const PFLogInViewPasswordFieldAccessibilityIdentifier = @"PFLogInViewPasswordFieldAccessibilityIdentifier";
+NSString *const PFLogInViewLogInButtonAccessibilityIdentifier = @"PFLogInViewLogInButtonAccessibilityIdentifier";
+NSString *const PFLogInViewSignUpButtonAccessibilityIdentifier = @"PFLogInViewSignUpButtonAccessibilityIdentifier";
+NSString *const PFLogInViewPasswordForgottenButtonAccessibilityIdentifier = @"PFLogInViewPasswordForgottenButtonAccessibilityIdentifier";
+NSString *const PFLogInViewTwitterButtonAccessibilityIdentifier = @"PFLogInViewTwitterButtonAccessibilityIdentifier";
+NSString *const PFLogInViewFacebookButtonAccessibilityIdentifier = @"PFLogInViewFacebookButtonAccessibilityIdentifier";
+NSString *const PFLogInViewDismissButtonAccessibilityIdentifier = @"PFLogInViewDismissButtonAccessibilityIdentifier";
 
 @implementation PFLogInView
 
@@ -174,7 +176,7 @@ - (void)_updateAllFields {
     if (_fields & PFLogInFieldsPasswordForgotten) {
         if (!_passwordForgottenButton) {
             _passwordForgottenButton = [[PFTextButton alloc] initWithFrame:CGRectZero];
-            _passwordForgottenButton.accessibilityIdentifier = PFLogInViewPasswordForgottenButotnAccessibilityIdentifier;
+            _passwordForgottenButton.accessibilityIdentifier = PFLogInViewPasswordForgottenButtonAccessibilityIdentifier;
             [_passwordForgottenButton setTitle:PFLocalizedString(@"Forgot Password?", "Forgot Password?")
                                       forState:UIControlStateNormal];
             [self addSubview:_passwordForgottenButton];

ParseUI/Classes/SignUpViewController/PFSignUpView.h

@@ -51,16 +51,16 @@ typedef NS_OPTIONS(NSInteger, PFSignUpFields) {
 
 
 /**
- `PFSignUpFields`'s accessibilities labels
+ `PFSignUpFields`'s accessibity identifiers
  
  @see PFSignUpView
  */
-extern NSString * const PFSignUpViewUsernameFieldAccessibilityIdentifier;
-extern NSString * const PFSignUpViewEmailFieldAccessibilityIdentifier;
-extern NSString * const PFSignUpViewPasswordFieldAccessibilityIdentifier;
-extern NSString * const PFSignUpViewAdditionalFieldAccessibilityIdentifier;
-extern NSString * const PFSignUpViewSignUpButtonAccessibilityIdentifier;
-extern NSString * const PFSignUpViewDismissButtonAccessibilityIdentifier;
+extern NSString *const PFSignUpViewUsernameFieldAccessibilityIdentifier;
+extern NSString *const PFSignUpViewEmailFieldAccessibilityIdentifier;
+extern NSString *const PFSignUpViewPasswordFieldAccessibilityIdentifier;
+extern NSString *const PFSignUpViewAdditionalFieldAccessibilityIdentifier;
+extern NSString *const PFSignUpViewSignUpButtonAccessibilityIdentifier;
+extern NSString *const PFSignUpViewDismissButtonAccessibilityIdentifier;
 
 
 @class PFTextField;

ParseUI/Classes/SignUpViewController/PFSignUpView.m

@@ -32,13 +32,15 @@
 
 static NSString *const PFSignUpViewDefaultLogoImageName = @"parse_logo.png";
 
-#pragma mark - Accessibility labels
-NSString * const PFSignUpViewUsernameFieldAccessibilityIdentifier = @"username";
-NSString * const PFSignUpViewEmailFieldAccessibilityIdentifier = @"email";
-NSString * const PFSignUpViewPasswordFieldAccessibilityIdentifier = @"password";
-NSString * const PFSignUpViewAdditionalFieldAccessibilityIdentifier = @"additional";
-NSString * const PFSignUpViewSignUpButtonAccessibilityIdentifier = @"sign up";
-NSString * const PFSignUpViewDismissButtonAccessibilityIdentifier = @"dismiss";
+///--------------------------------------
+#pragma mark - Accessibility Identifiers
+///--------------------------------------
+NSString *const PFSignUpViewUsernameFieldAccessibilityIdentifier = @"PFSignUpViewUsernameFieldAccessibilityIdentifier";
+NSString *const PFSignUpViewEmailFieldAccessibilityIdentifier = @"PFSignUpViewEmailFieldAccessibilityIdentifier";
+NSString *const PFSignUpViewPasswordFieldAccessibilityIdentifier = @"PFSignUpViewPasswordFieldAccessibilityIdentifier";
+NSString *const PFSignUpViewAdditionalFieldAccessibilityIdentifier = @"PFSignUpViewAdditionalFieldAccessibilityIdentifier";
+NSString *const PFSignUpViewSignUpButtonAccessibilityIdentifier = @"PFSignUpViewSignUpButtonAccessibilityIdentifier";
+NSString *const PFSignUpViewDismissButtonAccessibilityIdentifier = @"PFSignUpViewDismissButtonAccessibilityIdentifier";
 
 @implementation PFSignUpView