Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Updates for bolts 1.9.0 #142

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

felix-dumit
Copy link
Contributor

Small changes to make this library compatible with the latest 1.9.0 Bolts release.

@flovilmart
Copy link
Contributor

We’ll new to bump the Parse SDK as well, working on a release now

@ijameelkhan
Copy link

this still having issues.

screen shot 2018-01-03 at 4 54 26 pm

@InstaRobot
Copy link

InstaRobot commented Jan 7, 2018

ijameelkhan you can fix the error by replacing files in project's Pods folder from original Bolts-Swift repository

Bolts-Swift repository

It works fine for me!

@felix-dumit
Copy link
Contributor Author

felix-dumit commented Jan 27, 2018

@flovilmart I updated to 2.3.0 but then I started to get this error on compile:

Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_BFTaskCompletionSource", referenced from:
      objc-class-ref in BoltsHelpers.o

I had to add an explicit dependency to Bolts to fix it 422dcc2

@flovilmart
Copy link
Contributor

@felix-dummit this is very odd that the dependency to bolts need to be explicit as it should be provided by the Parse SDK itself. But i’ll Have a look. Also we’re almost releasing the 1.7.0 branch for the Parse SDK which contains proper error handling As bolts 1.9 remove support for catching exceptions and was making the SDK crash

@felix-dumit
Copy link
Contributor Author

Ok I was able to fix it. Turns out I had Parse and Parse/FacebookUtils in my podfile.
Removing it I was able to use 2.3.0

@Vortec4800
Copy link

Vortec4800 commented Apr 17, 2018

I'm having this exact same problem now, upgrading Parse to 1.17.x and LiveQuery to 2.4.x.

EDIT: Was able to fix this by manually adding Bolts to the list of linked frameworks for the ParseLiveQuery framework in the Pods project. Seems like adding Bolts as a dependency in the Podfile does this automatically, but this PR hasn't been merged yet so it's not happening at the moment.

@15458434
Copy link

When is this going to get merged?

@flovilmart
Copy link
Contributor

@15458434 you should not need this PR, the latest release 2.4.0 should be fine on it’s own

@Vortec4800
Copy link

I can confirm the latest 2.4.0 release still has this issue, and this PR is still necessary to tell Cocoapods that it depends on Bolts so it gets linked.

@felix-dumit felix-dumit force-pushed the bolts-update branch 6 times, most recently from 8ee1b32 to f46322c Compare April 22, 2018 01:29
@felix-dumit felix-dumit changed the base branch from master to release-2.4.0 April 22, 2018 01:29
@felix-dumit felix-dumit changed the base branch from release-2.4.0 to master April 22, 2018 01:30
@flovilmart flovilmart merged commit f69a272 into parse-community:master May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants