Add experimental OkHttp3 websocket client support #19
Conversation
This may become unnecessary if/when we move to OkHttp3 (parse-community#19). But for now it's the only way to see the exact JSON data that is being sent over the websocket.
This may become unnecessary if/when we move to OkHttp3 (#19). But for now it's the only way to see the exact JSON data that is being sent over the websocket.
|
|
||
| private OkHttp3WebSocketClient(WebSocketClientCallback webSocketClientCallback, URI hostUrl) { | ||
| this.webSocketClientCallback = webSocketClientCallback; | ||
| client = new OkHttpClient(); |
There was a problem hiding this comment.
since we don't reuse the client, maybe we should only create it in the open() method when creating the websocket?
There was a problem hiding this comment.
I've created two constructors now, one default that instantiates one, and another that allows you to pass one in...
There was a problem hiding this comment.
Mmm not sure to understand. Maybe my comment wasn't clear.
Why did you add the ability to pass a OkHttpClient? Is it useful?
There was a problem hiding this comment.
Yes adding a custom OkHttpClient Is useful for troubleshooting and custom options:
https://code.facebook.com/posts/393927910787513/stetho-a-new-debugging-platform-for-android/
There was a problem hiding this comment.
OK thanks for the clarification.
rogerhu
force-pushed
the
okhttp3
branch
2 times, most recently
from
087dbd2 to
8c4241d
Compare
| private final WebSocketClientCallback webSocketClientCallback; | ||
| private WebSocket webSocket; | ||
| private State state = State.NONE; | ||
| private OkHttpClient client; |
There was a problem hiding this comment.
You could make it final.
We should deprecate TubeSocket if this works.
We should deprecate TubeSocket if this works.
@mmimeault