Skip to content

Fix an issue with persistent bad authData on failure to link a user. #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Fix an issue with persistent bad authData on failure to link a user. #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Parse/PFUser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,14 +878,19 @@ - (BFTask *)linkWithAuthTypeInBackground:(NSString *)authType authData:(NSDictio
return [[self saveAsync:nil] continueAsyncWithBlock:^id(BFTask *task) {
if (task.result) {
[self synchronizeAuthDataWithAuthType:authType];
} else {
@synchronized (self.lock) {
[self.authData removeObjectForKey:authType];
[self.linkedServiceNames removeObject:authType];
[self restoreAnonymity:oldAnonymousData];
}
return task;
}

@synchronized (self.lock) {
[self.authData removeObjectForKey:authType];
[self.linkedServiceNames removeObject:authType];
[self restoreAnonymity:oldAnonymousData];
}
return task;
// Save the user to disk in case of failure, since we want the latest succeeded data persistent.
PFCurrentUserController *controller = [[self class] currentUserController];
return [[controller saveCurrentObjectAsync:self] continueWithBlock:^id(BFTask *_) {
return task; // Roll-forward the result of a save to network, not local save.
}];
}];
}];
}];
Expand Down