Use errors instead of exceptions when creating a PFFile. #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (![fileManager fileExistsAtPath:path isDirectory:&directory] || directory) { | ||
| NSString *message = [NSString stringWithFormat:@"Failed to create PFFile at path '%@': " | ||
| "file does not exist.", path]; | ||
| *error = [NSError errorWithDomain:PFParseErrorDomain |
There was a problem hiding this comment.
2 things here:
- let's use
PFErrorUtilitiesto create an error, since it enforces PFParseErrorDomain, as well as logs to console by default. - We should fine a code that fits this best from existing error codes, or avoid using
PFParseErrorDomain, since we have a guarantee that we never use anything other than errors defined in PFConstants (PFErrorCode) enum.
|
Looks great, minus usage of errors. |
richardjrossiii
force-pushed
the
richardross.file.error
branch
from
192564f to
0492b05
Compare
| @"PFFile cannot be larger than %llu bytes", PFFileMaxFileSize); | ||
| if (!data) { | ||
| NSString *message = @"Cannot create a PFFile with nil data."; | ||
| *error = [NSError errorWithDomain:NSPOSIXErrorDomain |
There was a problem hiding this comment.
Let's use NSCocoaErrorDomain with maybe NSFileNoSuchFileError?
|
Be aware - Travis failed miserably on this one. |
richardjrossiii
force-pushed
the
richardross.file.error
branch
from
0492b05 to
05e4990
Compare
Switching to errors provides a more consistent interface, as we should never use exceptions in objective-c except for unrecoverable errors. Fixes #338.
|
Ship it! |
richardjrossiii
added a commit
that referenced
this pull request
Sep 29, 2015
Use errors instead of exceptions when creating a PFFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to errors provides a more consistent interface, as we should never use exceptions in objective-c except for unrecoverable errors.
Fixes #338.