Fixed deadlock in -collectDirtyChildren: #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjrossiii
force-pushed
the
richardross.collectdirtychildren.deadlock
branch
from
eaaadfc to
e8b9c53
Compare
|
Rebase on master? |
|
Get your rebates folks! Parse, now 50% off! 😁 💵 Like I said in the description. Keeping this one on mutable containers so we can have some of our users more easily test it. |
|
LGTM |
By no longer holding a lock while recursing, we allow other threads who may be waiting on the current object to progress before iterating to children of the object, solving some of the deadlocks that we've seen in issues #11, #61, and #299. This does not necessarily fix the above issues, as we probably still have similar deadlocks elsewhere in the codebase. cc @grantland
richardjrossiii
force-pushed
the
richardross.collectdirtychildren.deadlock
branch
from
e8b9c53 to
da2df65
Compare
richardjrossiii
added a commit
that referenced
this pull request
Sep 23, 2015
…ildren.deadlock Fixed deadlock in -collectDirtyChildren:
richardjrossiii
deleted the
richardross.collectdirtychildren.deadlock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By no longer holding a lock while recursing, we allow other threads who may be waiting on the current object to progress before iterating to children of the object, solving some of the deadlocks that we've seen in issues #11, #61, and #299.
This does not necessarily fix the above issues, as we probably still have similar deadlocks elsewhere in the codebase.
This is based on the mutable containers branch until the time comes to land this, as we want some of our users to be able to test this, and mutable containers also contains deadlocks.
cc @grantland