Fix flaky PurchaseControllerTests.testDownloadAsync test. #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.tests.flaky
branch
from
275242b to
04eddbc
Compare
|
LGTM |
nlutsenko
added a commit
that referenced
this pull request
Sep 4, 2015
Fix flaky PurchaseControllerTests.testDownloadAsync test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky on Travis because running the command doesn't happen asynchronously, but rather inline (it's mocked to reply with an already completed task) - so sometimes it's completing the overall task faster than it can report progress. Added another expectation for that to make sure that we get a progress callback always.