Replace exceptions in PFUser.signUp with errors. #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.user.exceptions
branch
from
35dde95 to
1bb6c88
Compare
|
LGTM, but why does it need to be async? |
|
I need a BFTask return type there, so simply named it with |
nlutsenko
force-pushed
the
nlutsenko.user.exceptions
branch
from
1bb6c88 to
dbfd19e
Compare
nlutsenko
added a commit
that referenced
this pull request
Sep 6, 2015
Replace exceptions in PFUser.signUp with errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all exceptions with errors, so we don't crash end applications, but rather fail signup requests.
Contributes to #6