Apple user details #1551
Apple user details #1551
Conversation
|
Just a thought... we could also include the user object in the new callback to make it easier to assign the values. |
|
Carthage target is broken here it seems, and Carthage is more generally broken with Xcode 12, which is what I've got installed locally. Downloading 11.7 to see if I can reproduce it. |
|
Æh... this Travis CI - Branch target seems to be.. hesitant. Not sure if this is because I needed to rerun some targets to get them green. Same thing seems to be happening in #1543. |
|
Yeah definitely meeting some resistance from CI atm |
iOS tests are still temperamental.
|
@TomWFox About this 'Travis CI - Branch' target that never seems to complete... this is a new thing that seemed to appear along with the 'Required' labels. What should it be executing? |
|
@cbaker6 What was the deal with codecov suddenly thinking we're down to 6%? |
|
I'm guessing the iOS or macOS builds failed to send it's report. If so, you may have to run it again. |
| @@ -72,9 +72,7 @@ workflows: | |||
| jobs: | |||
| - ios | |||
| - macos | |||
| - carthage: | |||
| requires: | |||
There was a problem hiding this comment.
I believe removing this may allow Carthage to run before iOS (I think the jobs start randomly and the only thing that prevents it is "requires"). Also, Carthage takes the longest, so if the iOS build fails, no reason to run Carthage because it will likely fail. Better to find out quickly that iOS failed than wait until after Carthage
There was a problem hiding this comment.
Yeah I meant to explain myself here. My reasoning was that the iOS tests still fail randomly; that the tests fail doesn't mean the binary isn't good. And if there's been an issue with the Carthage build, working on getting it green is a crapshoot.
It's more of a hack to deal with what we've got, than the right solution.
|
Update, in Circle for iOS, you got a "fail to send" for codecov on the previous build |
Aha! |
This is because the branch you created for this PR exists on the parse-community repo, so it running the test there also. It should report at some point, it's probably just bring slow because these builds are slow. |
It shouldn't take weeks though, right? |
Definitely not, @TomWFox can probably remove the requirement. It's probably a bug on github and travis side |
|
I'll remove the requirement. Not certain but I'm pretty sure I've seen this issue of Travis CI - Branch reporting intermittently. |
|
Just spotted the @import. Seem to recall it causing issues in some other context in this project. EDIT: Sry import. Didn't mean to ping you 😬. |
* Updates version numbers * Updates changelog * Apple user details (#1551) * Adds callback to PFLoginViewController for received Apple credentials object * Adds user to Apple credential callback * Fixes target membership * Cleans up target membership * Removes CCI Carthage build dependency on iOS. iOS tests are still temperamental. * Removes @import * Allow Parse SDK to be built for maccatalyst (#1543) * allow Parse SDK to be built for maccatalyst * Updates version numbers * Updates changelog * changed minimumosversion to 8.0 (#1521) * changed minimumosversion to 8.0 closes #1515 * Updates version numbers * Updates changelog * Update changelog * nits Co-authored-by: Martin Man <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: Tom Fox <[email protected]>
This PR adds a callback to PFLoginViewController to allow developers to receive the one-time credentials and user details object from Sign In With Apple. By adding an extra callback method for this, we avoid breaking existing installs. But documentation needs updating.