Set bolts back to 1.8.4 #1236
Closed
Set bolts back to 1.8.4 #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flovilmart do we want to revert first and then work on #1237, or focus on just that (it is the fix for this right?). |
|
Yeah, i’m Not sure, i’d rather not revert as bolts has a breaking Swift API :/ let’s see how far I can go |
|
Gotcha, let's hold until we see whether you can work it out in the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we have a proper solution for not throwing exceptions within tasks (error passing across the SDK?) We have to properly continue to function without throwing errors.
This reverts bolts to 1.8.4, which still has the task exception handling.