Skip to content

Allow disabling retry logic #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natanrolnik opened this issue Nov 26, 2015 · 6 comments
Closed

Allow disabling retry logic #607

natanrolnik opened this issue Nov 26, 2015 · 6 comments
Labels
type:feature New feature or improvement of existing feature

Comments

@natanrolnik
Copy link
Contributor

Hey Parsers!

One issue that has been annoying me for months, when the SDK wasn't open source - but now it is so I remembered I can discuss it.

In some case in my app, there is no point where some calls should automatically retry to succeed. Simple example: In my login view controller, if the user mistakenly disabled wi-fi, I want to be able to show as soon as possible that the request failed. But right now, the SDK tries a few times before passing back the error calling the completion block.

Is it very complicated to give the developers some option to disable the retry logic?

@nlutsenko nlutsenko self-assigned this Nov 30, 2015
@nlutsenko
Copy link
Contributor

Agreed, this is a good candidate for a new configuration logic being discussed in #570
Marking as enhancement, we should take a look at it...

@natanrolnik
Copy link
Contributor Author

Awesome! Indeed, #570 is needed as many additions and improvements are added to the framework.

@richardjrossiii
Copy link
Contributor

@natanrolnik I just updated #570 with the ability to disable/adjust the retry attempts used in the SDK. Let me know what your thoughts on the APIs that have been proposed.

@natanrolnik
Copy link
Contributor Author

Hey @richardjrossiii it's looking good!
From what I see, it will work as a per-request count correct?

This is coming in 1.11.0 or more probably in 1.12.0?

@richardjrossiii
Copy link
Contributor

@natanrolnik This is still preliminary. We're looking to roll out new configuration APIs across all platforms already (.NET exists, Java still in progress). Hopefully 1.11, but more likely 1.12.

And yes, the retry count is on a per-request basis.

@nlutsenko
Copy link
Contributor

This was released in #570.

@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

4 participants