handle MissingRequiredFieldError exception (code 135)

Author: hermanliang

Parse/PFConstants.h

@@ -219,6 +219,10 @@ typedef NS_ENUM(NSInteger, PFErrorCode) {
      The email address was invalid.
      */
     kPFErrorInvalidEmailAddress = 125,
+    /**
+     Required field is missing.
+     */
+    kPFErrorMissingRequiredField = 135,
     /**
      A unique field was given a value that is already taken.
      */

Parse/PFInstallation.m

@@ -234,7 +234,8 @@ - (void)setChannels:(NSArray<NSString *> *)channels {
 
 - (BFTask *)saveAsync:(BFTask *)toAwait {
     return [[super saveAsync:toAwait] continueWithBlock:^id(BFTask *task) {
-        if (task.error.code == kPFErrorObjectNotFound) {
+        if (task.error.code == kPFErrorObjectNotFound
+            || (task.error.code == kPFErrorMissingRequiredField && self.objectId == nil)) {
             @synchronized (self.lock) {
                 // Retry the fetch as a save operation because this Installation was deleted on the server.
                 // We always want [currentInstallation save] to succeed.

Tests/Unit/InstallationUnitTests.m

@@ -29,7 +29,26 @@ - (void)testInstallationObjectIdCannotBeChanged {
     PFAssertThrowsInvalidArgumentException(installation[@"objectId"] = @"abc");
 }
 
-- (void)testReSaveInstallation {
+- (void)testMissingRequiredFieldWhenSave {
+    // mocking installation was deleted on the server
+    id commandRunner = PFStrictProtocolMock(@protocol(PFCommandRunning));
+    [Parse _currentManager].commandRunner = commandRunner;
+    BFTask *mockedTask = [BFTask taskWithError:[NSError errorWithDomain:@"" code:kPFErrorMissingRequiredField userInfo:nil]];
+    __block int callCount = 0;
+    OCMStub([commandRunner runCommandAsync:[OCMArg any] withOptions:PFCommandRunningOptionRetryIfFailed])
+    .andReturn(mockedTask)
+    .andDo(^(NSInvocation *invocation) {
+        callCount++;
+    });
+    
+    PFInstallation *installation = [PFInstallation currentInstallation];
+    installation.deviceToken = @"11433856eed2f1285fb3aa11136718c1198ed5647875096952c66bf8cb976306";
+    [installation save];
+    OCMVerifyAll(commandRunner);
+    XCTAssertEqual(2, callCount);
+}
+
+- (void)testObjectNotFoundWhenSave {
 
     // enable LDS
     [[Parse _currentManager]loadOfflineStoreWithOptions:0];
@@ -46,11 +65,17 @@ - (void)testReSaveInstallation {
 
     BFTask *mockedTask = [BFTask taskWithError:[NSError errorWithDomain:@"" code:kPFErrorObjectNotFound userInfo:nil]];
 
-    OCMStub([commandRunner runCommandAsync:[OCMArg any] withOptions:PFCommandRunningOptionRetryIfFailed]).andReturn(mockedTask);
+    __block int callCount = 0;
+    OCMStub([commandRunner runCommandAsync:[OCMArg any] withOptions:PFCommandRunningOptionRetryIfFailed])
+    .andReturn(mockedTask)
+    .andDo(^(NSInvocation *invocation) {
+        callCount++;
+    });
 
     installation.deviceToken = @"11433856eed2f1285fb3aa11136718c1198ed5647875096952c66bf8cb976306";
     [installation save];
     OCMVerifyAll(commandRunner);
+    XCTAssertEqual(2, callCount);
 }
 
 - (void)testInstallationImmutableFieldsCannotBeChanged {