Do no track dimensions if they are nil

flovilmart · flovilmart · commit ea2fa1a6cee6 · 2018-01-30T09:44:29.000-05:00
diff --git a/Parse/Parse/Internal/Analytics/Controller/PFAnalyticsController.m b/Parse/Parse/Internal/Analytics/Controller/PFAnalyticsController.m
@@ -79,7 +79,7 @@ + (instancetype)controllerWithDataSource:(id<PFEventuallyQueueProvider>)dataSour
         @strongify(self);
         NSError *error;
         NSDictionary *encodedDimensions = [[PFNoObjectEncoder objectEncoder] encodeObject:dimensions error:&error];
-        if (encodedDimensions == nil && error != nil) {
+        if (encodedDimensions == nil) {
             return [BFTask taskWithError:error];
         }
         PFRESTCommand *command = [PFRESTAnalyticsCommand trackEventCommandWithEventName:name

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ + (instancetype)controllerWithDataSource:(id<PFEventuallyQueueProvider>)dataSour`
`79`	`79`	`@strongify(self);`
`80`	`80`	`NSError *error;`
`81`	`81`	`NSDictionary *encodedDimensions = [[PFNoObjectEncoder objectEncoder] encodeObject:dimensions error:&error];`
`82`		`- if (encodedDimensions == nil && error != nil) {`
	`82`	`+ if (encodedDimensions == nil) {`
`83`	`83`	`return [BFTask taskWithError:error];`
`84`	`84`	`}`
`85`	`85`	`PFRESTCommand *command = [PFRESTAnalyticsCommand trackEventCommandWithEventName:name`