Skip to content

Adds Purge & Polygon to Parse.Schema #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jan 16, 2018

This adds the purge method to ParseSchema. This allows the deletion of all objects without having to run through and query all objects for removal. This was added to ParseSchema as the related delete method requires the class to be first empty of objects.

Polygon type support has also been added to ParseSchema, both via a supported method to add a polygon type field and as a recognized field when asserting types.

@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #544 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   84.62%   84.66%   +0.04%     
==========================================
  Files          48       48              
  Lines        3960     3971      +11     
  Branches      900      900              
==========================================
+ Hits         3351     3362      +11     
  Misses        609      609
Impacted Files Coverage Δ
src/CoreManager.js 100% <100%> (ø) ⬆️
src/ParseError.js 100% <100%> (ø) ⬆️
src/ParseSchema.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef1b0a...45df22c. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Jan 27, 2018

@flovilmart @montymxb I forgot I left this here.

@dplewis
Copy link
Member Author

dplewis commented Jan 28, 2018

I wish I could merge this :)

@flovilmart flovilmart merged commit 741958a into parse-community:master Jan 28, 2018
@dplewis dplewis deleted the purge-polygon-schema branch January 28, 2018 01:37
@flovilmart
Copy link
Contributor

@dplewis I’ll add you to the JS maintainers :)

@dplewis
Copy link
Member Author

dplewis commented Jan 28, 2018

@flovilmart 🙏

@montymxb
Copy link
Contributor

montymxb commented Feb 1, 2018

Awesome, another person to help with PRs here!

@dplewis
Copy link
Member Author

dplewis commented Feb 1, 2018

@montymxb Welcome back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants