Skip to content

docs: remove alpha branch chapter from README #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

franklanganke
Copy link
Contributor

@franklanganke franklanganke commented Nov 5, 2021

New Pull Request Checklist

Issue Description

Update default branch name

Related issue: #1422

Approach

  • update readme.md

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 5, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Nov 5, 2021

Thanks for pointing this out! I am not sure whether we want to keep that paragraph at all. We now have 2 branches (alpha, release) + in the future maybe beta + N LTS branches (release-N.x.x). To explain only the alpha branch seems a bit arbitrary. We actually have a better branch explanation in the changelog already, which is likely more prominent than that last paragraph in the README.

To avoid keeping redundant info that has to maintained separately, I suggest we just remove the whole paragraph (and the TOC entry).

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title docs: update default branch name docs: remove alpha branch chapter from README Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1430 (c3037fb) into alpha (a2026d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            alpha    #1430   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5948     5948           
  Branches     1354     1354           
=======================================
  Hits         5945     5945           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2026d3...c3037fb. Read the comment docs.

@mtrezza mtrezza merged commit 10a2e5b into parse-community:alpha Nov 5, 2021
@franklanganke franklanganke deleted the patch-1 branch November 6, 2021 09:45
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 5, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants