Skip to content

(docs): Improve IncludeAll description #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021
Merged

(docs): Improve IncludeAll description #1337

merged 1 commit into from
Apr 8, 2021

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 8, 2021

Closes: #1336

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1337 (fa323f0) into master (3a96900) will not change coverage.
The diff coverage is n/a.

❗ Current head fa323f0 differs from pull request most recent head 303990b. Consider uploading reports for the commit 303990b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          60       60           
  Lines        5847     5847           
  Branches     1311     1311           
=======================================
  Hits         5844     5844           
  Misses          3        3           
Impacted Files Coverage Δ
src/ParseQuery.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a96900...303990b. Read the comment docs.

@dplewis dplewis requested review from davimacedo and mtrezza April 8, 2021 15:58
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR ever 😁

@dplewis dplewis merged commit a1995ba into master Apr 8, 2021
@dplewis dplewis deleted the includeAll-doc branch April 8, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeAll() includes first layer of nested children objects, not multiple
2 participants