Skip to content

fix(LocalDatastore): Allow Pin of unsaved Parse.Object #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 12, 2020

Closes: #1118

Let me know if more tests are needed. Can be improved in the future.

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #1225 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1225   +/-   ##
=======================================
  Coverage   92.36%   92.37%           
=======================================
  Files          54       54           
  Lines        5307     5313    +6     
  Branches     1195     1197    +2     
=======================================
+ Hits         4902     4908    +6     
  Misses        405      405           
Impacted Files Coverage Δ
src/LocalDatastore.js 99.13% <100.00%> (ø)
src/ParseObject.js 90.50% <100.00%> (+0.04%) ⬆️
src/ParseOp.js 82.07% <100.00%> (ø)
src/encode.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba5809...0893e6d. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. LGTM!

@dplewis dplewis merged commit db555e3 into master Sep 17, 2020
@dplewis dplewis deleted the fix-lds-unpin branch September 17, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Pin of unsaved Parse.Object with an unsaved, but pinned, Parse.Object pointer
2 participants