Skip to content

feat(ParseQuery): support using aggregate on top of constructed query #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RaschidJFR
Copy link
Contributor

@RaschidJFR RaschidJFR commented May 23, 2020

Closes #1171

Enable using a constructed query with aggregate, passing the where key to the aggregate pipeline as match.

Example:

await new Parse.Query(TestObject)
  .equalTo('name', 'foo')
  .aggregate(pipeline);  // This now aggregates only objects with name 'foo'

See #1171 for further details.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1170 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   92.38%   92.34%   -0.04%     
==========================================
  Files          54       54              
  Lines        5290     5293       +3     
  Branches     1189     1191       +2     
==========================================
+ Hits         4887     4888       +1     
- Misses        403      405       +2     
Impacted Files Coverage Δ
src/ParseQuery.js 96.00% <33.33%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f30a38...f88959f. Read the comment docs.

@dplewis dplewis merged commit 5561d82 into parse-community:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack ParseQuery.aggregate() on top of a constructed Query
2 participants