Add WebSocketController to CoreManager

Allows for swappable WebSocket implementation.

Author: dplewis

package-lock.json

@@ -136,7 +136,14 @@ type HooksController = {
   update: (hook: mixed) => Promise;
   send: (method: string, path: string, body?: mixed) => Promise;
 };
-
+type WebSocketController = {
+  onopen: () => void;
+  onmessage: (message: any) => void;
+  onclose: () => void;
+  onerror: (error: any) => void;
+  send: (data: any) => void;
+  close: () => void;
+}
 type Config = {
   AnalyticsController?: AnalyticsController,
   CloudController?: CloudController,
@@ -154,6 +161,7 @@ type Config = {
   LocalDatastoreController?: LocalDatastoreController,
   UserController?: UserController,
   HooksController?: HooksController,
+  WebSocketController?: WebSocketController,
 };
 
 const config: Config & { [key: string]: mixed } = {
@@ -370,6 +378,14 @@ module.exports = {
     return config['AsyncStorage'];
   },
 
+  setWebSocketController(controller: WebSocketController) {
+    config['WebSocketController'] = controller;
+  },
+
+  getWebSocketController(): WebSocketController {
+    return config['WebSocketController'];
+  },
+
   setUserController(controller: UserController) {
     requireMethods('UserController', [
       'setCurrentUser',

src/CoreManager.js

@@ -238,7 +238,7 @@ class LiveQueryClient extends EventEmitter {
    *
    */
   open() {
-    const WebSocketImplementation = this._getWebSocketImplementation();
+    const WebSocketImplementation = CoreManager.getWebSocketController();
     if (!WebSocketImplementation) {
       this.emit(CLIENT_EMMITER_TYPES.ERROR, 'Can not find WebSocket implementation');
       return;
@@ -248,7 +248,6 @@ class LiveQueryClient extends EventEmitter {
       this.state = CLIENT_STATE.CONNECTING;
     }
 
-    // Get WebSocket implementation
     this.socket = new WebSocketImplementation(this.serverURL);
 
     // Bind WebSocket callbacks
@@ -316,18 +315,6 @@ class LiveQueryClient extends EventEmitter {
     this.emit(CLIENT_EMMITER_TYPES.CLOSE);
   }
 
-  _getWebSocketImplementation(): any {
-    if (process.env.PARSE_BUILD === 'node') {
-      return require('ws');
-    } else if (process.env.PARSE_BUILD === 'browser') {
-      return typeof WebSocket === 'function' || typeof WebSocket === 'object' ? WebSocket : null;
-    } else if (process.env.PARSE_BUILD === 'weapp') {
-      return require('./Socket.weapp');
-    } else if (process.env.PARSE_BUILD === 'react-native') {
-      return WebSocket;
-    }
-  }
-
   // ensure we start with valid state if connect is called again after close
   _handleReset() {
     this.attempts = 1;
@@ -463,4 +450,14 @@ class LiveQueryClient extends EventEmitter {
   }
 }
 
+if (process.env.PARSE_BUILD === 'node') {
+  CoreManager.setWebSocketController(require('ws'));
+} else if (process.env.PARSE_BUILD === 'browser') {
+  CoreManager.setWebSocketController(typeof WebSocket === 'function' || typeof WebSocket === 'object' ? WebSocket : null);
+} else if (process.env.PARSE_BUILD === 'weapp') {
+  CoreManager.setWebSocketController(require('./Socket.weapp'));
+} else if (process.env.PARSE_BUILD === 'react-native') {
+  CoreManager.setWebSocketController(WebSocket);
+}
+
 export default LiveQueryClient;

src/LiveQueryClient.js

@@ -26,9 +26,11 @@ module.exports = class SocketWeapp {
     })
   }
 
-  send(msg) {
-    wx.sendSocketMessage({
-      data: msg
-    })
+  send(data) {
+    wx.sendSocketMessage({ data });
+  }
+
+  close() {
+    wx.closeSocket();
   }
 }

src/Socket.weapp.js

@@ -381,4 +381,18 @@ describe('CoreManager', () => {
     CoreManager.setLocalDatastoreController(controller);
     expect(CoreManager.getLocalDatastoreController()).toBe(controller);
   });
+
+  it('can set and get WebSocketController', () => {
+    const controller = {
+      onopen: function() {},
+      onmessage: function() {},
+      onclose: function() {},
+      onerror: function() {},
+      send: function() {},
+      close: function() {},
+    };
+
+    CoreManager.setWebSocketController(controller);
+    expect(CoreManager.getWebSocketController()).toBe(controller);
+  });
 });