Skip to content

Correction to FCM module name #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Correction to FCM module name #833

wants to merge 1 commit into from

Conversation

Jawnnypoo
Copy link
Member

No description provided.

@Jawnnypoo
Copy link
Member Author

To match with #830

@Jawnnypoo Jawnnypoo requested a review from rogerhu May 25, 2018 16:18
@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #833 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #833      +/-   ##
============================================
- Coverage     54.11%   54.09%   -0.03%     
  Complexity     1682     1682              
============================================
  Files           123      123              
  Lines          9736     9736              
  Branches       1361     1361              
============================================
- Hits           5269     5267       -2     
- Misses         4039     4040       +1     
- Partials        428      429       +1
Impacted Files Coverage Δ Complexity Δ
...se/src/main/java/com/parse/ParseKeyValueCache.java 43% <0%> (-2%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6240840...484cf79. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 58.515% when pulling 484cf79 on Jawnnypoo-patch-1 into 6240840 on master.

@@ -5,7 +5,7 @@ group = 'com.parse'

ext {
projDescription = 'Parse Android FCM support.'
artifact = 'parse-fcm-android'
artifact = 'parse-android-fcm'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the README instructions too?

@Jawnnypoo Jawnnypoo closed this May 29, 2018
@Jawnnypoo
Copy link
Member Author

Lets just rename them in the docs since it seems like the rest of the libs follow this structure, ie. parse-ui-android

@Jawnnypoo Jawnnypoo deleted the Jawnnypoo-patch-1 branch May 29, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants