Implement ParseAuthenticationManager #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantland
force-pushed
the
grantland.authentication_controller
branch
2 times, most recently
from
7892ca6 to
f1fcda4
Compare
grantland
changed the title
| } | ||
|
|
||
| public void register(ParseAuthenticationProvider provider) { | ||
| final String authType = provider.getAuthType(); |
There was a problem hiding this comment.
Maybe add an exception around authType should not be nil?
|
Just few nits, nothing big, love the approach. |
|
LGTM, Awesome! |
* Decouples managing ParseAuthentication providers, convert deauthenticate to async * Convert ParseAuthenticationProvider into a interface
grantland
force-pushed
the
grantland.authentication_controller
branch
from
1311d73 to
6bc204b
Compare
grantland
added a commit
that referenced
this pull request
Sep 9, 2015
…ntroller Implement ParseAuthenticationManager
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async.