Revert #648 #655
Merged
Revert #648 #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
=========================================
Coverage 52.85% 52.85%
Complexity 1676 1676
=========================================
Files 131 131
Lines 10148 10148
Branches 1408 1408
=========================================
Hits 5364 5364
Misses 4341 4341
Partials 443 443
Continue to review full report at Codecov.
|
hermanliang
reviewed
May 4, 2017
| * This executor should be used for any network operation, in all subclasses. | ||
| * Chaining network operations with tasks consumed by Task.BACKGROUND_EXECUTOR , which is smaller, | ||
| * will cause performance bottlenecks and possibly lock the whole SDK. | ||
| */ | ||
| protected static final ExecutorService NETWORK_EXECUTOR = newThreadPoolExecutor( |
There was a problem hiding this comment.
should also revert to package private?
There was a problem hiding this comment.
In the future I think it will make sense to move all custom executors (network executor, db executor) to the ParseExecutors class that exists already... but let’s fix this bolts issue first
rogerhu
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #648 because we lately discovered that the issue is much deeper and this was wrong.