Allow the GcmBroadcastReceiver to be subclassed

[mmimeault]

You can only define one Broadcast Receiver to act as a GCM receiver.
In our case, we want to receive pushes from Parse and another provider. So I was going to write a Proxy that wrap both receivers.

But the Parse SDK prevent that by doing a strong validation of the Manifest. (https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ManifestInfo.java#L446-L448)
The GCM receiver defined need to be explicitly an instance of GcmBroadcastReceiver.
And that class can't be extended as the onReceive method is final.
(If the validations do not pass, the PushType is None and the registration will not happen) (https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ManifestInfo.java#L212-L214)

The current PR is a proposition.
But there are many solutions to my problem.

• Remove the final
• Remove the strong validation
• other suggestion

[codecov]

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #638   +/-   ##
=========================================
  Coverage     52.86%   52.86%           
  Complexity     1676     1676           
=========================================
  Files           131      131           
  Lines         10146    10146           
  Branches       1408     1408           
=========================================
  Hits           5364     5364           
  Misses         4339     4339           
  Partials        443      443

Impacted Files	Coverage Δ	Complexity Δ
.../src/main/java/com/parse/GcmBroadcastReceiver.java	0% <ø> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c650b2c...ec63659. Read the comment docs.

[natario1]

Just curious, how are you going to get the gcm receiver instance to call add on it?

[mmimeault]

In the constructor of a class extending it. (protected method). You call add for each other receiver.

But I would prefer just remove the final on the onReceive signature.
I don't really understand why the SDK add that limitation.

One or the other is good for me.

[natario1]

I would also rather remove the final and maybe add the @CallSuper annotation

[Jawnnypoo]

@CallSuper is a part of the support annotations library, which Parse does not currently have as a dependency. But I would be happy if it did!

[natario1]

I think we have it.. ? https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/build.gradle#L47

[Jawnnypoo]

Ahh, I stand corrected. +1 for @CallSuper then!

[natario1]

Not sure when it was introduced, but it would be great to also annotate the rest of the SDK (thinking mostly of @nullable and @nonnull )

[mmimeault]

Anyway... it doesn't work because of that
https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ManifestInfo.java#L368-L378

The class declared needs to be GcmBroadcastReceiver.class, not only an instanceOf.

Do anybody know why there is so much validation around that GCM receiver?
https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ManifestInfo.java#L212-L214

We are using mixpanel push system and we want also to use parse for differents campaign.
I would really like to have both working together.

[rogerhu]

Speaking of which, does anyone have bandwidth to consider ripping out GCMService and putting them into a separate repo? Sort of like ParseGCM like we have for Parse Facebook.

This way people can start using Firebase GCM v4 but this library would provide all the necessary setup to make things work with Parse (i.e. InstandID service)

See: #445

[Jawnnypoo]

@rogerhu Do you think it needs to be its own repo? Maybe it would be better to just have it as another module in this repo? (which could be deployed as its own dependency)

[rogerhu]

I think the challenge is that when you deploy via Gradle, it will attempt to deploy across all modules unless you explicitly specify it.

If it makes things easier to get started, we can do it until we're ready to release..

[rogerhu]

rebase

[rogerhu]

one more rebase needed

[racheal31ayers]

On Apr 27, 2017 1:04 PM, "Roger Hu" <[email protected]> wrote: rebase — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#638 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZO67nOTMEL1WymJC_cGyphdkdS5qD40ks5r0MqCgaJpZM4NAsK0> .

[parse-github-assistant]

The label type:feature cannot be used here.