Download ParseFile content to file instead of memory #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.t8120706_download_ParseFile_content_to_file_instead_of_memory
branch
2 times, most recently
from
00e0b3a to
6d20873
Compare
|
|
||
| public ParseAWSRequest(Method method, String url) { | ||
| // The temp file is used to save the ParseFile content when we fetch it from server | ||
| private File tempFile; |
| } | ||
|
|
||
| @Override | ||
| protected Task<byte[]> onResponseAsync(ParseHttpResponse response, | ||
| protected Task<Void> onResponseAsync(ParseHttpResponse response, |
There was a problem hiding this comment.
We should probably do the operations in this method on ParseExecutors.io() since we're doing disk i/o now or else we'd be on ParseRequest.NETWORK_EXECUTOR by default.
There was a problem hiding this comment.
oops, forgot this point, sorry.
|
It seems like we're going to have to have a proper solution for managing our cache. I'll create a new issue for it. |
|
Can you rebase master? It looks like there are conflicts with master. |
wangmengyan95
force-pushed
the
wangmengyan.t8120706_download_ParseFile_content_to_file_instead_of_memory
branch
from
efe3382 to
dd591a9
Compare
|
LGTM |
wangmengyan95
added a commit
that referenced
this pull request
Sep 3, 2015
…ad_ParseFile_content_to_file_instead_of_memory Download ParseFile content to file instead of memory
wangmengyan95
deleted the
wangmengyan.t8120706_download_ParseFile_content_to_file_instead_of_memory
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.