Skip to content

Removed file size check, Parse Android SDK #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2016

Conversation

kristoprifti
Copy link

No description provided.

@kristoprifti
Copy link
Author

@grantland i did a new PR if it is not a problem. Can you please check this one ? everything is in one commit this time

@ghost
Copy link

ghost commented May 24, 2016

By analyzing the blame information on this pull request, we identified @daisuke-nomura and @wangmengyan95 to be potential reviewers.

@grantland
Copy link
Contributor

Looks good! Merging

Fixes #453

@grantland grantland merged commit 758f236 into parse-community:master May 24, 2016
@kristoprifti
Copy link
Author

@grantland how can i apply these changes to my project ? bcs the 1.13 version is still the same, Will you guys release a new version or smth ?

@grantland grantland modified the milestone: 1.13.1 May 25, 2016
@kristoprifti
Copy link
Author

@grantland Hello. I wanted to ask about the next milestone release date since we have our app in production and we would really appreciate an update :)

@grantland
Copy link
Contributor

No planned date at the moment, but currently waiting on two more changes: https://github.com/ParsePlatform/Parse-SDK-Android/milestones/1.13.1

@kristoprifti
Copy link
Author

@grantland can you set up a due date for the latest milestone ? as i mentioned before, we have our app in production and we really need to update our Parse library for Android. Can we move the unresolved issue to another milestone and release the current one ?

@grantland
Copy link
Contributor

Done, currently set to Wednesday.

@kristoprifti
Copy link
Author

@grantland when will the milestone be published so we can use it ? Do we need to do something in our side ?

@grantland
Copy link
Contributor

I just pushed it. You'll need to target the latest version and let it filter throughout the Maven repository.

@munl
Copy link

munl commented Oct 19, 2016

Hi has this code been pushed yet? I'm using:
compile 'com.parse:parse-android:1.+'
to compile parse, but I'm still getting the "java.lang.IllegalArgumentException: ParseFile must be less than 10485760 bytes" exception

@kristoprifti
Copy link
Author

@munl you need to use 1.13.1 version of Parse. This code has been pushed long time ago and i personally dont get this problem anymore :)

@tran-huy-phuc
Copy link

@kristoprifti I am using 1.13.1 but still getting the exception. Do you have any hint?

@kristoprifti
Copy link
Author

@thphuc these are the changes i did to remove the file size check and this is applied in 1.13.1. Please double check with ParseFile.java in your project if it still contains the lines i removed. Otherwise if the problem still persists you can download the version 1.13.0 as a separate project and include it as a dependency, then you can make the changes I did manually and you can also debug further when you get the exception :) i hope it helps!

https://github.com/ParsePlatform/Parse-SDK-Android/pull/462/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants