For open source Parse with /parse mounts, this fix helps avoid the problem of remembering to add the trailing slash. #436

rogerhu · 2016-04-07T16:49:16Z

No description provided.

facebook-github-bot · 2016-04-07T16:49:48Z

By analyzing the blame information on this pull request, we identified @richardjrossiii, @grantland and @wangmengyan95 to be potential reviewers.

facebook-github-bot · 2016-04-07T17:10:48Z

@rogerhu updated the pull request.

grantland · 2016-04-07T18:49:05Z

@richardjrossiii Could you take a look at this?

richardjrossiii · 2016-04-07T21:53:38Z

Parse/src/test/java/com/parse/ParseClientConfigurationTest.java

@@ -30,14 +30,14 @@ public void testBuilder() {
    Parse.Configuration.Builder builder = new Parse.Configuration.Builder(null);
    builder.applicationId("foo");
    builder.clientKey("bar");
-    builder.server("some.server");
+    builder.server("http://myserver.com/parse");


Can we perhaps duplicate this test case, instead of just modifying it in-place? One test for each branch?

richardjrossiii · 2016-04-07T21:54:20Z

I'd prefer we use String.endsWith() instead of charAt(), even if the performance of the latter is better. Seems more clear to me.

facebook-github-bot · 2016-04-07T21:58:59Z

@rogerhu updated the pull request.

…oblem of remembering to add the trailing slash.

facebook-github-bot · 2016-04-07T22:05:20Z

@rogerhu updated the pull request.

rogerhu · 2016-04-07T22:07:38Z

Fixed...can you take a look again? I took out the server() on the original test and broke them out to separate tests to check both cases.

richardjrossiii · 2016-04-08T00:46:15Z

Nice! Merging now.

rogerhu · 2016-04-08T00:49:02Z

Thanks!

posativ · 2016-04-25T17:00:44Z

Example traceback for GitHub's search.

com.parse.ParseRequest$ParseRequestException: bad json response
    at com.parse.ParseRequest.newTemporaryException(ParseRequest.java:290)
    at com.parse.ParseRESTCommand.onResponseAsync(ParseRESTCommand.java:308)
    at com.parse.ParseRequest$3.then(ParseRequest.java:137)
    at com.parse.ParseRequest$3.then(ParseRequest.java:133)
    at bolts.Task$15.run(Task.java:917)
    at bolts.BoltsExecutors$ImmediateExecutor.execute(BoltsExecutors.java:105)
    at bolts.Task.completeAfterTask(Task.java:908)
    at bolts.Task.continueWithTask(Task.java:715)
    at bolts.Task.continueWithTask(Task.java:726)
    at bolts.Task$13.then(Task.java:818)
    at bolts.Task$13.then(Task.java:806)
    at bolts.Task$15.run(Task.java:917)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
    at java.lang.Thread.run(Thread.java:818)
Caused by: org.json.JSONException: Value Cannot of type java.lang.String cannot be converted to JSONObject
    at org.json.JSON.typeMismatch(JSON.java:111)
    at org.json.JSONObject.<init>(JSONObject.java:160)
    at org.json.JSONObject.<init>(JSONObject.java:173)
    at com.parse.ParseRESTCommand.onResponseAsync(ParseRESTCommand.java:298)
    ... 13 more

rogerhu · 2016-04-26T16:59:53Z

Could you explain what this has to do with this PR?

posativ · 2016-04-26T17:38:05Z

You run into this error when you're not using the master (that includes this fix) and you cannot find it easily.

rogerhu · 2016-04-26T17:49:22Z

Could you provide a code sample? How is this PR related to your issue?

On Tue, Apr 26, 2016 at 10:38 AM, Martin Zimmermann <
[email protected]> wrote:

You run into this error when you're not using the master and you cannot
find it easily.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#436 (comment)

posativ · 2016-04-26T18:03:53Z

If you use the latest release of Parse SDK for Android with a custom Parse server hosted on e.g. foo.example.org:4043/foobar and forget to add a slash, you get this nonsense error message.

The PR resolves this.

If it still doesn't make sense, remove my comments.

rogerhu · 2016-04-26T18:40:06Z

Yes we should release a new version right? :)

On Tue, Apr 26, 2016 at 11:04 AM, Martin Zimmermann <
[email protected]> wrote:

If you use the latest release of Parse SDK for Android with a custom Parse
server hosted on e.g. foo.example.org:4043/foobar and forget to add a
slash, you get this nonsense error message.

The PR resolves this.

If it still doesn't make sense, remove my comments.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#436 (comment)

posativ · 2016-04-26T19:06:36Z

Yup, might save a few hours questionig the self-hosted server ;)

rogerhu · 2016-04-26T19:09:56Z

Can someone make this happen?

facebook-github-bot added GH Review: review-needed labels Apr 7, 2016

rogerhu force-pushed the parse_slash branch from 2cd9d5c to f461b5c Compare April 7, 2016 17:10

grantland assigned richardjrossiii Apr 7, 2016

richardjrossiii reviewed Apr 7, 2016
View reviewed changes

richardjrossiii added GH Review: needs-revision and removed GH Review: review-needed labels Apr 7, 2016

rogerhu force-pushed the parse_slash branch from f461b5c to 2627da8 Compare April 7, 2016 21:58

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels Apr 7, 2016

rogerhu force-pushed the parse_slash branch from 2627da8 to 6d8163f Compare April 7, 2016 21:59

For open source Parse with /parse mounts, this fix helps avoid the pr…

f108ea1

…oblem of remembering to add the trailing slash.

rogerhu force-pushed the parse_slash branch from 6d8163f to f108ea1 Compare April 7, 2016 22:01

richardjrossiii added GH Review: accepted and removed GH Review: review-needed labels Apr 8, 2016

richardjrossiii merged commit 95b6b17 into parse-community:master Apr 8, 2016

htoooth mentioned this pull request Apr 21, 2016

For open source Parse with /parse mounts, this fix helps avoid the pr… htoooth/Parse-SDK-Android#1

Merged

grantland modified the milestone: 1.13.1 May 25, 2016

grantland mentioned this pull request Jun 27, 2016

if you use sdk version is 1.13.0 #456

Closed

lacker unassigned richardjrossiii Apr 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For open source Parse with /parse mounts, this fix helps avoid the problem of remembering to add the trailing slash. #436

For open source Parse with /parse mounts, this fix helps avoid the problem of remembering to add the trailing slash. #436

rogerhu commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

grantland commented Apr 7, 2016

richardjrossiii Apr 7, 2016

richardjrossiii commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

rogerhu commented Apr 7, 2016

richardjrossiii commented Apr 8, 2016

rogerhu commented Apr 8, 2016

posativ commented Apr 25, 2016

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016 •

edited

Loading

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016

rogerhu commented Apr 26, 2016

For open source Parse with /parse mounts, this fix helps avoid the problem of remembering to add the trailing slash. #436

For open source Parse with /parse mounts, this fix helps avoid the problem of remembering to add the trailing slash. #436

Conversation

rogerhu commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

grantland commented Apr 7, 2016

richardjrossiii Apr 7, 2016

Choose a reason for hiding this comment

richardjrossiii commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

facebook-github-bot commented Apr 7, 2016

rogerhu commented Apr 7, 2016

richardjrossiii commented Apr 8, 2016

rogerhu commented Apr 8, 2016

posativ commented Apr 25, 2016

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016 • edited Loading

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016

rogerhu commented Apr 26, 2016

posativ commented Apr 26, 2016 •

edited

Loading