Fix: Unable to receive null response from Cloud Code #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`res.success(null)` from Cloud Code caused `ParseCloud.callFunctionInBackground()` to return a JSONObject, which would result in `ClassCastException` in developer code since they would normally expect a `String` or something. This change fixes that.
grantland
added
type:bug
| result = jsonResult.get("result"); | ||
| } catch (JSONException e) { | ||
| return result; | ||
| } |
There was a problem hiding this comment.
jsonResult.get("result") would throw a JSONException, which caused this function to return {} instead of null
|
LGTM |
grantland
added a commit
that referenced
this pull request
Aug 19, 2015
Fix: Unable to receive null response from Cloud Code
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res.success(null)from Cloud Code causedParseCloud.callFunctionInBackground()to return aJSONObject, which would result inClassCastExceptionin developer code since they would normally expect aStringor something.This change fixes that.
/cc @hallucinogen @wangmengyan95 @nlutsenko