Push Translation #29
Merged
Push Translation #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #28 |
| // rewrite depreciated two-letter codes | ||
| if (language.equals("iw")) language = "he"; // Hebrew | ||
| if (language.equals("in")) language = "id"; // Indonesian | ||
| if (language.equals("ji")) language = "yi"; // Yiddish |
There was a problem hiding this comment.
Let's add a unit test to verify that we're correctly persisting these 3 locales.
lukas1994
force-pushed
the
push.translation
branch
from
bf7d95b to
1a512a2
Compare
| ParsePlugins.reset(); | ||
| } | ||
|
|
||
| private void mocksForUpdateBeforeSave() { |
There was a problem hiding this comment.
nit: make static and move to the bottom of the class
|
Two minor changes and we're good to go! |
added locale/language detection localeIdentifier gets automatically populated whenever an installation is saved/updated
lukas1994
force-pushed
the
push.translation
branch
from
1a512a2 to
915faa9
Compare
|
LGTM! For future PRs, please submit changes as new commits so it's easier to review changes in between updates as well as @ me since I don't get notifications when you update your PR. When it's all ready we'll ask you to squash. Thanks! |
grantland
assigned hallucinogen and lukas1994 and unassigned grantland and hallucinogen
|
@lukas1994 updated the pull request. |
|
The label |
parse-github-assistant
bot
removed
the
type:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added locale/language detection
localeIdentifier gets automatically populated whenever an installation is saved/updated