Skip to content

Fixed #7 - Keep WeakReference to parent ParseObject in ParseRelation #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2015
Merged

Fixed #7 - Keep WeakReference to parent ParseObject in ParseRelation #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions Parse/src/main/java/com/parse/ParseRelation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*/
package com.parse;

import java.lang.ref.WeakReference;
import java.util.Collections;
import java.util.HashSet;
import java.util.Set;
Expand All @@ -24,7 +25,13 @@ public class ParseRelation<T extends ParseObject> {
private final Object mutex = new Object();

// The owning object of this ParseRelation.
private ParseObject parent;
private WeakReference<ParseObject> parent;

// The object Id of the parent.
private String parentObjectId;

// The classname of the parent to retrieve the parent ParseObject in case the parent is GC'ed.
private String parentClassName;

// The key of the relation in the parent object.
private String key;
Expand All @@ -36,13 +43,17 @@ public class ParseRelation<T extends ParseObject> {
private Set<ParseObject> knownObjects = new HashSet<>();

/* package */ ParseRelation(ParseObject parent, String key) {
this.parent = parent;
this.parent = new WeakReference<>(parent);
this.parentObjectId = parent.getObjectId();
this.parentClassName = parent.getClassName();
this.key = key;
this.targetClass = null;
}

/* package */ ParseRelation(String targetClass) {
this.parent = null;
this.parentObjectId = null;
this.parentClassName = null;
this.key = null;
this.targetClass = targetClass;
}
Expand All @@ -52,6 +63,8 @@ public class ParseRelation<T extends ParseObject> {
*/
/* package */ ParseRelation(JSONObject jsonObject, ParseDecoder decoder) {
this.parent = null;
this.parentObjectId = null;
this.parentClassName = null;
this.key = null;
this.targetClass = jsonObject.optString("className", null);
JSONArray objectsArray = jsonObject.optJSONArray("objects");
Expand All @@ -65,12 +78,14 @@ public class ParseRelation<T extends ParseObject> {
/* package */ void ensureParentAndKey(ParseObject someParent, String someKey) {
synchronized (mutex) {
if (parent == null) {
parent = someParent;
parent = new WeakReference<>(someParent);
parentObjectId = someParent.getObjectId();
parentClassName = someParent.getClassName();
}
if (key == null) {
key = someKey;
}
if (parent != someParent) {
if (parent.get() != someParent) {
throw new IllegalStateException(
"Internal error. One ParseRelation retrieved from two different ParseObjects.");
}
Expand All @@ -92,7 +107,7 @@ public void add(T object) {
ParseRelationOperation<T> operation =
new ParseRelationOperation<>(Collections.singleton(object), null);
targetClass = operation.getTargetClass();
parent.performOperation(key, operation);
getParent().performOperation(key, operation);

knownObjects.add(object);
}
Expand All @@ -109,7 +124,7 @@ public void remove(T object) {
ParseRelationOperation<T> operation =
new ParseRelationOperation<>(null, Collections.singleton(object));
targetClass = operation.getTargetClass();
parent.performOperation(key, operation);
getParent().performOperation(key, operation);

knownObjects.remove(object);
}
Expand All @@ -124,12 +139,12 @@ public ParseQuery<T> getQuery() {
synchronized (mutex) {
ParseQuery.State.Builder<T> builder;
if (targetClass == null) {
builder = new ParseQuery.State.Builder<T>(parent.getClassName())
builder = new ParseQuery.State.Builder<T>(parentClassName)
.redirectClassNameForKey(key);
} else {
builder = new ParseQuery.State.Builder<>(targetClass);
}
builder.whereRelatedTo(parent, key);
builder.whereRelatedTo(getParent(), key);
return new ParseQuery<>(builder);
}
}
Expand Down Expand Up @@ -193,7 +208,13 @@ public ParseQuery<T> getQuery() {
}

/* package for tests */ ParseObject getParent() {
return parent;
if(parent == null){
return null;
}
if(parent.get() == null){
return ParseObject.createWithoutData(parentClassName, parentObjectId);
}
return parent.get();
}

/* package for tests */ String getKey() {
Expand Down