Remove GET_ACCOUNTS requirement in Parse #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET_ACCOUNTS is only required for GCM on devices running lower than 4.0.4. This will allow developers to leave out this permission if they are targetting 4.0.4+. This also removes some trailing whitespace.
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
| "<uses-permission android:name=\"android.permission.ACCESS_NETWORK_STATE\" />\n" + | ||
| "<uses-permission android:name=\"android.permission.VIBRATE\" />\n" + | ||
| "<uses-permission android:name=\"android.permission.WAKE_LOCK\" />\n" + | ||
| "<uses-permission android:name=\"android.permission.GET_ACCOUNTS\" />\n" + |
There was a problem hiding this comment.
seems like we should remove this from the comment
|
seems safe to merge. i'll leave the decision over whether you want to include the permission in the comment up to you. |
|
I think it's safer to keep the permission there, as it could be a reason that Parse isn't working. |
grantland
added a commit
that referenced
this pull request
Oct 27, 2015
Remove GET_ACCOUNTS requirement in Parse
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET_ACCOUNTS is only required for GCM on devices running lower than 4.0.4.
This will allow developers to leave out this permission if they are targetting
4.0.4+.
This also removes some trailing whitespace.
Resolves #129