-
-
Notifications
You must be signed in to change notification settings - Fork 735
refactor: replace startActivityForResult with ActivityResultLauncher #1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
@Shvet can you please review all checkboxes in the description? |
Codecov Report
Continue to review full report at Codecov.
|
that would be helpful, we want to separate issue discussion from PR (solution) discussion.
passes now |
Added issue |
@L3K0V Do you think we can merge this? |
@mtrezza LGTM |
🎉 This change has been released in version 3.0.1 |
New Pull Request Checklist
Issue Description
Related issue:
startActivityForReuslt was deprecated in adnroidx and replace with ActivityResultLauncher. So i have edited
Login
method and addedActivityResultLauncher<Intent>
as a variable.Approach
login
method has new variable forActivityResultLauncher<Intent>
which can be replaced forstartActivityForResult
.for example:
TODOs before merging