Adapt to Futures 0.1.15 by not using boxed() (#196)

* Add local BoxFuture and use it

* Stop using boxed() in core

* Stop using boxed() in ws

* Stop using boxed() in tcp

* Stop using boxed() in http

* Stop using boxed() in minihttp

* Stop using boxed() in macros

* Stop using boxed() in ipc

* Remove unused imports

* Stop using boxed() in pubsub

* Remove unused crates

Author: faern

core/README.md

@@ -49,7 +49,7 @@ use jsonrpc_core::futures::Future;
 fn main() {
 	let io = IoHandler::new();
 	io.add_async_method("say_hello", |_params: Params| {
-		futures::finished(Value::String("hello".into())).boxed()
+		Box::new(futures::finished(Value::String("hello".into())))
 	});
 
 	let request = r#"{"jsonrpc": "2.0", "method": "say_hello", "params": [42, 23], "id": 1}"#;

core/examples/middlewares.rs

@@ -22,10 +22,10 @@ impl Middleware<Meta> for MyMiddleware {
 		let request_number = self.0.fetch_add(1, atomic::Ordering::SeqCst);
 		println!("Processing request {}: {:?}, {:?}", request_number, request, meta);
 
-		next(request, meta).map(move |res| {
+		Box::new(next(request, meta).map(move |res| {
 			println!("Processing took: {:?}", start.elapsed());
 			res
-		}).boxed()
+		}))
 	}
 }
 

core/src/calls.rs

@@ -1,6 +1,7 @@
 use std::sync::Arc;
 use types::{Params, Value, Error};
-use futures::{BoxFuture, Future};
+use futures::Future;
+use BoxFuture;
 
 /// Metadata trait
 pub trait Metadata: Default + Clone + Send + 'static {}
@@ -60,7 +61,7 @@ impl<F: Send + Sync + 'static, X: Send + 'static> RpcMethodSimple for F where
 	X: Future<Item=Value, Error=Error>,
 {
 	fn call(&self, params: Params) -> BoxFuture<Value, Error> {
-		self(params).boxed()
+		Box::new(self(params))
 	}
 }
 
@@ -78,7 +79,7 @@ impl<F: Send + Sync + 'static, X: Send + 'static, T> RpcMethod<T> for F where
 	X: Future<Item=Value, Error=Error>,
 {
 	fn call(&self, params: Params, meta: T) -> BoxFuture<Value, Error> {
-		self(params, meta).boxed()
+		Box::new(self(params, meta))
 	}
 }
 

core/src/io.rs

@@ -3,12 +3,13 @@ use std::collections::HashMap;
 use std::ops::{Deref, DerefMut};
 
 use serde_json;
-use futures::{self, future, Future, BoxFuture};
+use futures::{self, future, Future};
 
 use calls::{RemoteProcedure, Metadata, RpcMethodSync, RpcMethodSimple, RpcMethod, RpcNotificationSimple, RpcNotification};
 use middleware::{self, Middleware};
 use types::{Params, Error, ErrorCode, Version};
 use types::{Request, Response, Call, Output};
+use BoxFuture;
 
 /// A type representing middleware or RPC response before serialization.
 pub type FutureResponse = BoxFuture<Option<Response>, ()>;
@@ -178,11 +179,11 @@ impl<T: Metadata, S: Middleware<T>> MetaIoHandler<T, S> {
 			Ok(request) => B(self.handle_rpc_request(request, meta)),
 		};
 
-		result.map(|response| {
+		Box::new(result.map(|response| {
 			let res = response.map(write_response);
 			debug!(target: "rpc", "Response: {:?}.", res);
 			res
-		}).boxed()
+		}))
 	}
 
 	/// Handle deserialized RPC request.
@@ -234,9 +235,9 @@ impl<T: Metadata, S: Middleware<T>> MetaIoHandler<T, S> {
 				};
 
 				match result {
-					Ok(result) => A(result
+					Ok(result) => A(Box::new(result
 						.then(move |result| futures::finished(Some(Output::from(result, id, jsonrpc))))
-						.boxed()),
+						)),
 					Err(err) => B(futures::finished(Some(Output::from(Err(err), id, jsonrpc)))),
 				}
 			},

core/src/lib.rs

@@ -36,6 +36,9 @@ mod io;
 mod middleware;
 pub mod types;
 
+/// A `Future` trait object.
+pub type BoxFuture<T, E> = Box<futures::Future<Item = T, Error = E> + Send>;
+
 pub use calls::{RemoteProcedure, Metadata, RpcMethodSync, RpcMethodSimple, RpcMethod, RpcNotificationSimple, RpcNotification};
 pub use io::{Compatibility, IoHandler, MetaIoHandler, FutureResponse};
 pub use middleware::{Middleware, Noop as NoopMiddleware};

core/src/middleware.rs

@@ -2,7 +2,8 @@
 
 use calls::Metadata;
 use types::{Request, Response};
-use futures::{Future, BoxFuture};
+use futures::Future;
+use BoxFuture;
 
 /// RPC middleware
 pub trait Middleware<M: Metadata>: Send + Sync + 'static {
@@ -27,7 +28,7 @@ impl<M: Metadata> Middleware<M> for Noop {
 		F: FnOnce(Request, M) -> X + Send,
 		X: Future<Item=Option<Response>, Error=()> + Send + 'static,
 	{
-		process(request, meta).boxed()
+		Box::new(process(request, meta))
 	}
 }
 

http/src/handler.rs

@@ -7,8 +7,8 @@ use hyper::{self, mime, server, Method};
 use hyper::header::{self, Headers};
 use unicase::Ascii;
 
-use jsonrpc::{Metadata, Middleware, NoopMiddleware};
-use jsonrpc::futures::{Future, Poll, Async, BoxFuture, Stream};
+use jsonrpc::{BoxFuture, Metadata, Middleware, NoopMiddleware};
+use jsonrpc::futures::{Future, Poll, Async, Stream};
 use response::Response;
 use server_utils::cors;
 

http/src/lib.rs

@@ -38,8 +38,8 @@ use std::sync::{mpsc, Arc};
 use std::net::SocketAddr;
 
 use hyper::server;
-use jsonrpc::MetaIoHandler;
-use jsonrpc::futures::{self, Future, IntoFuture, BoxFuture, Stream};
+use jsonrpc::{BoxFuture, MetaIoHandler};
+use jsonrpc::futures::{self, Future, IntoFuture, Stream};
 use jsonrpc::futures::sync::oneshot;
 use server_utils::reactor::{Remote, UninitializedRemote};
 
@@ -132,7 +132,7 @@ impl<T> From<Option<T>> for RequestMiddlewareAction where
 			},
 			Some(handler) => RequestMiddlewareAction::Respond {
 				should_validate_hosts: true,
-				handler: handler.into_future().boxed(),
+				handler: Box::new(handler.into_future()),
 			},
 		}
 	}

http/src/tests.rs

@@ -21,15 +21,15 @@ fn serve() -> Server {
 	let mut io = IoHandler::default();
 	io.add_method("hello", |_params: Params| Ok(Value::String("world".into())));
 	io.add_async_method("hello_async", |_params: Params| {
-		futures::finished(Value::String("world".into())).boxed()
+		Box::new(futures::finished(Value::String("world".into())))
 	});
 	io.add_async_method("hello_async2", |_params: Params| {
 		let (c, p) = futures::oneshot();
 		thread::spawn(move || {
 			thread::sleep(::std::time::Duration::from_millis(10));
 			c.send(Value::String("world".into())).unwrap();
 		});
-		p.map_err(|_| Error::invalid_request()).boxed()
+		Box::new(p.map_err(|_| Error::invalid_request()))
 	});
 
 	ServerBuilder::new(io)

ipc/Cargo.toml

@@ -14,7 +14,6 @@ tokio-service = "0.1"
 jsonrpc-core = { version = "7.1", path = "../core" }
 jsonrpc-server-utils = { version = "7.1", path = "../server-utils" }
 parity-tokio-ipc = { git = "https://github.com/nikvolf/parity-tokio-ipc" }
-bytes = "0.4"
 
 [dev-dependencies]
 env_logger = "0.4"