Add checkquote function without using the tpm2

[brandsimon]

No description provided.

[brandsimon]

I did not update any packages, but got the following error:

error: rustc 1.78.0 is not supported by the following package:
  [email protected] requires rustc 1.81

Is this expected?

[baloo]

Not exactly a review but a couple of improvements on this PR: brandsimon#6

[baloo]

I did not update any packages, but got the following error:

error: rustc 1.78.0 is not supported by the following package:
  [email protected] requires rustc 1.81

Is this expected?

#572
Something forgotten in #537

[baloo]

Here is a followup to fix the rsa pkcs1v15 signature check: brandsimon#7

[baloo]

You can rebase on main to fix the three tests.

[brandsimon]

@baloo Thank you very very much for your work.
The verification functions are a lot cleaner now!

I did some changes so cargo fmt and cargo clippy succeed. From my side, this is ready to merge.

[wiktor-k]

I think this looks very nice 👌 just a couple of nits/questions.

[brandsimon]

@wiktor-k
Thank you, all done!
The clippy failures are also on main and I think because of a new version of clippy.

[brandsimon]

I fixed the clippy issues in #575
Once merged, I rebase onto main.

[Superhepper]

It is my personal preference to try to avoid names like common, utils, e.t.c because they tend to end up becoming a garbage can full of "nice to have things". And it has been one of my personal goals to try to get rid of the utils module once and for all.

With that said. I would much rather have this put under abstraction. And if you want to be really specific about it you could even create a sub module in there called no_tpm.

hrmm or maybe a no_tpm module along side abstraction would be best. Because I guess it will contain more things that want to used the TPM structures for compatibility reasons.

[wiktor-k]

It is my personal preference to try to avoid names like common, utils, e.t.c because they tend to end up becoming a garbage can full of "nice to have things". And it has been one of my personal goals to try to get rid of the utils module once and for all.

FWIW I agree with this perspective and also don't like utils, helpers, etc.

[wiktor-k]

LGTM. FWIW you can fix the sign-offs with git rebase --signoff main && git push --force-with-lease... or... well... since it's just last commit I guess git commit --amend --signoff --no-edit would work too :)

[brandsimon]

@wiktor-k
Thank you, signed-off the last commit

[baloo]

The use of PrehashVerifier should be swapped with DigestVerifier just so we stay off the hazmat.

RustCrypto/elliptic-curves#1146