Skip to content

Update crates #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

gowthamsk-arm
Copy link
Contributor

This MR has the following changes:

  • Bump parsec-related crates
  • Cargo update changes
  • Update docker image to Ubuntu 22.04

Signed-off-by: Gowtham Suresh Kumar [email protected]

@gowthamsk-arm gowthamsk-arm requested a review from a team as a code owner March 20, 2023 19:34
@gowthamsk-arm gowthamsk-arm force-pushed the update_crates branch 3 times, most recently from 823039b to 2c64310 Compare March 21, 2023 06:39
The cross compilation of the latest psa-crypto sys crate fails for
aarch64 target on a ubuntu 18.04 machine. This is due to the 0.63.0
version of bindgen in psa-crypto-sys. The latest bindgen crate has
a check which compares size_t, ssize_t with target pointer and aborts
if they are unequal when size_t_is_usize flag is set. In ubuntu 18.04
these are read as 4 and 8 bytes respectively which is wrong. This is
an issue with the c library mismatchs of target toolchains in 18.04.
Hence we are updating the docker test image to 22.04. Also, 18.04 is
reaching end of life in April 2023.

This commit involves the following changes:
- Use ubuntu 22.04 as base image
- Dependency packages missing in 22.04 have been added
- Tpm library versions have been bumped as 22.04 has openssl > 3.0
- Older version libts used to generate keys has been removed as
  the missing dependencies for it causes compilation issues.
  Instead we use parsec 1.0.0 which uses a libts version which is
  compatible with 22.04 for generating keys for both SQLite and
  OnDisk KIM.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>

 # OnDisk KIM.
As part of the release, we need to use all the latest parsec crates and
bump versions of other crates to use a single version.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The lock file changes in this commit are due to the cargo update
command issued to bump the crate versions.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Copy link
Collaborator

@anta5010 anta5010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@adamjohnstonarm adamjohnstonarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gowthamsk-arm
Copy link
Contributor Author

Closes #663

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for all the effort that went into this! 🙏🏻

@gowthamsk-arm gowthamsk-arm merged commit f7eda93 into parallaxsecond:main Mar 21, 2023
@gowthamsk-arm gowthamsk-arm deleted the update_crates branch October 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants