Replace println calls with log crate #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
reviewed
Oct 18, 2019
.github/workflows/ci.yml
Outdated
| @@ -38,7 +38,7 @@ jobs: | |||
| - uses: actions/checkout@v1 | |||
| - run: cargo build --verbose | |||
| - run: | | |||
| cargo run & | |||
| RUST_LOG=info cargo run & | |||
There was a problem hiding this comment.
Could you also add RUST_BACKTRACE=1, please?
There was a problem hiding this comment.
Of course! That is, Ionut, an excellent suggestion.
Pulls in new changes from test client that already contains the switch to log commit. Adds an INFO log level in the test script, in the CI and in the systemd unit file. Signed-off-by: Hugues de Valon <[email protected]>
ionut-arm
approved these changes
Oct 18, 2019
|
Closes #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in new changes from test client that already contains the switch
to log commit.
Adds an INFO log level in the test script, in the CI and in the systemd
unit file.
Signed-off-by: Hugues de Valon [email protected]