Add SIGTERM handler for a graceful shutdown #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implement point 2 of #35 |
hug-dev
force-pushed
the
graceful-shutdown
branch
from
8b23a4c to
b923d8a
Compare
ionut-arm
reviewed
Oct 17, 2019
src/bin/main.rs
Outdated
| } | ||
|
|
||
| //TODO: this value should come from the configuration. | ||
| thread::sleep(Duration::from_millis(10)); |
There was a problem hiding this comment.
You can probably put this in an else branch above to "simulate" a timeout on the socket, so that you only sleep if there's no one waiting for a connection.
Changes the wait_for_connection function in the Listen trait to be non-blocking. That allows checking in the main loop if the SIGTERM signal has been raised. Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
graceful-shutdown
branch
from
b923d8a to
34b342d
Compare
ionut-arm
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the wait_for_connection function in the Listen trait to be
non-blocking. That allows checking in the main loop if the SIGTERM
signal has been raised.
Testing: