Skip to content

Add a JWT-SVID authenticator #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Nov 6, 2020

The authenticators validates a JWT SPIFFE Verifiable Identity Document.
Adds a configuration option to choose this new authenticator and also
adds tests for it.

@hug-dev
Copy link
Member Author

hug-dev commented Nov 6, 2020

This won't work until the changes are pushed in some rust-spiffe repository 🥇

@hug-dev hug-dev marked this pull request as draft November 6, 2020 16:59
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hug-dev hug-dev force-pushed the spiffe branch 16 times, most recently from 0febd92 to a77bd11 Compare November 26, 2020 11:35
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Minor/somewhat unrelated comments below

@hug-dev hug-dev marked this pull request as ready for review November 26, 2020 15:58
The authenticators validates a JWT SPIFFE Verifiable Identity Document.
Adds a configuration option to choose this new authenticator and also
adds tests for it.

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev merged commit a62e8cb into parallaxsecond:master Nov 26, 2020
@hug-dev hug-dev deleted the spiffe branch November 26, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a SPIFFE JWT-SVID multitenancy test Add a JWT-SVID Authenticator
2 participants