Implement mitigation 4 of TM #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds trace logging whenever requests, responses, mappings or commands are sent or received. Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
added
the
security
ionut-arm
approved these changes
Jun 23, 2020
| response | ||
| }; | ||
|
|
||
| // Serialise the response into bytes | ||
| // Write bytes to stream | ||
| match response.write_to_stream(&mut stream) { |
There was a problem hiding this comment.
Apologies for not asking this earlier, but why not just put a trace!("dispatch_request egress"); just before this match? Or did you not want to write it if the dispatcher wasn't called?
There was a problem hiding this comment.
Yes so that it is only written when the dispatcher has been called.
Comment on lines
+88
to
+97
| if crate::utils::GlobalConfig::log_error_details() { | ||
| if let Some(app_name_string) = app_name.clone() { | ||
| info!( | ||
| "New request received from application name \"{}\"", | ||
| app_name_string | ||
| ) | ||
| } else { | ||
| info!("New request received without authentication") | ||
| } | ||
| }; |
| @@ -209,6 +206,12 @@ impl OnDiskKeyInfoManager { | |||
| ))?, | |||
| ) { | |||
| Ok(key_triple) => { | |||
| if crate::utils::GlobalConfig::log_error_details() { | |||
There was a problem hiding this comment.
Maybe we should rename the flag to log_details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace logging whenever requests, responses, mappings or commands
are sent or received.
Signed-off-by: Hugues de Valon [email protected]