Skip to content

ListKeys should only be callable on the Core provider #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hug-dev opened this issue Jan 8, 2021 · 1 comment · Fixed by #313
Closed

ListKeys should only be callable on the Core provider #310

hug-dev opened this issue Jan 8, 2021 · 1 comment · Fixed by #313
Labels
bug Something isn't working

Comments

@hug-dev
Copy link
Member

hug-dev commented Jan 8, 2021

ListKeys is a core operation and should not be callable on crypto providers.
Reference: this, also this on Slack.

A test need to be added to make sure that PsaErrorNotSupported is returned when this operation is called on crypto providers.
@hug-dev hug-dev added the bug Something isn't working label Jan 8, 2021
This was referenced Jan 8, 2021
Closed
Closed
@hug-dev
Copy link
Member Author

hug-dev commented Jan 11, 2021

Actually we already check that here, but we should add a test for ListKeys.

hug-dev added a commit to hug-dev/parsec that referenced this issue Jan 11, 2021
@hug-dev
Add a test checking ListKeys provider target
aa1384f 
Fix parallaxsecond#310

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev mentioned this issue Jan 11, 2021
Merged
hug-dev added a commit to hug-dev/parsec that referenced this issue Jan 11, 2021
@hug-dev
Add a test checking ListKeys provider target
3ecc50a 
Fix parallaxsecond#310

Signed-off-by: Hugues de Valon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a test checking ListKeys provider target hug-dev/parsec
1 participant
@hug-dev