Skip to content

Add ListClients and DeleteClient operations #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Jan 13, 2021

Close #22

@hug-dev hug-dev requested a review from ionut-arm January 13, 2021 15:56
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you post a screenshot of the output? 😬

@ionut-arm
Copy link
Member

I was also wondering - do you think we should put a prompt before deleting a client, like "are you sure you want to delete...?"

@hug-dev
Copy link
Member Author

hug-dev commented Jan 14, 2021

Looks good, could you post a screenshot of the output? 😬

Yes sure, I will finish the implementation in Parsec and then post a screenshot of the test

I was also wondering - do you think we should put a prompt before deleting a client, like "are you sure you want to delete...?"

hmm not sure about that, I would say admin should know what they are doing 😋

@hug-dev
Copy link
Member Author

hug-dev commented Jan 14, 2021

image

Something like this!

@hug-dev
Copy link
Member Author

hug-dev commented Jan 15, 2021

Had forgotten to add a new line

@hug-dev hug-dev merged commit 90df3ea into parallaxsecond:master Jan 15, 2021
@hug-dev hug-dev deleted the list-clients branch January 15, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ListClients and DeleteClient
2 participants